All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemming@brocade.com>
To: Phil Sutter <phil@nwl.cc>
Cc: <netdev@vger.kernel.org>, Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [iproute PATCH] iptunnel: Fix compile error in ip/tunnel.c
Date: Mon, 21 Dec 2015 21:34:50 -0800	[thread overview]
Message-ID: <20151221213450.2dd96ef2@xeon-e3> (raw)
In-Reply-To: <20151221194131.636F061201@mail.nwl.cc>

On Mon, 21 Dec 2015 20:42:56 +0100
Phil Sutter <phil@nwl.cc> wrote:

> I repeatedly failed to get this right, so now I have to clean up my mess
> afterwards.
> 
> Fixes: 7d6aadcd0a1dc ("ip{,6}tunnel: have a shared stats parser/printer")
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
>  ip/tunnel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ip/tunnel.c b/ip/tunnel.c
> index 1dd8092..39f825b 100644
> --- a/ip/tunnel.c
> +++ b/ip/tunnel.c
> @@ -208,7 +208,7 @@ void tnl_print_stats(const char *buf)
>  		      tx_bytes, tx_packets, tx_errs, tx_drops,
>  		      tx_fifo, tx_colls, tx_carrier, rx_multi;
>  
> -	if (sscanf(ptr, "%lu%lu%lu%lu%lu%lu%lu%*d%lu%lu%lu%lu%lu%lu%lu",
> +	if (sscanf(buf, "%lu%lu%lu%lu%lu%lu%lu%*d%lu%lu%lu%lu%lu%lu%lu",
>  	           &rx_bytes, &rx_packets, &rx_errs, &rx_drops,
>  	           &rx_fifo, &rx_frame, &rx_multi,
>  	           &tx_bytes, &tx_packets, &tx_errs, &tx_drops,

Applied..

      reply	other threads:[~2015-12-22  5:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11 12:23 [iproute PATCH] ip{,6}tunnel: have a shared stats parser/printer Phil Sutter
2015-12-18  1:14 ` Stephen Hemminger
2015-12-18 10:52   ` Phil Sutter
2015-12-18 10:58     ` [iproute PATCH v2] " Phil Sutter
2015-12-18 19:47       ` Stephen Hemminger
2015-12-21 11:00       ` Daniel Borkmann
2015-12-21 19:36         ` Phil Sutter
2015-12-21 19:42         ` [iproute PATCH] iptunnel: Fix compile error in ip/tunnel.c Phil Sutter
2015-12-22  5:34           ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151221213450.2dd96ef2@xeon-e3 \
    --to=shemming@brocade.com \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.