All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH v2] staging: lustre: remove IOC_LIBCFS_PING_TEST ioctl
@ 2015-11-27  4:31 ` Dilger, Andreas
  0 siblings, 0 replies; 6+ messages in thread
From: Dilger, Andreas @ 2015-11-27  4:31 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Linus Torvalds, James Simmons, Drokin, Oleg, devel,
	Linux Kernel Mailing List, lustre-devel

On 2015/11/08, 09:34, "James Simmons" <jsimmons@infradead.org> wrote:

>The ioctl IOC_LIBCFS_PING_TEST has not been used in
>ages. The recent nidstring changes which moved all
>the nidstring operations from libcfs to the LNet
>layer but this ioctl code was still using an
>nidstring operation that was causing an circular
>dependency loop between libcfs and LNet:

Hi Greg,
are you planning on pushing this patch to Linus for 4.4?  It was resent
on 11/08 per your request on 11/07 but I don't see it in staging or
staging-next yet.  Since it fixes the depmod dependency cycle for
allmodconfig builds on mainline it seems worthwhile to include into
4.4-rc3 rather than waiting for 4.5.

Cheers, Andreas


>Signed-off-by: James Simmons <jsimmons@infradead.org>
>---
> .../lustre/include/linux/libcfs/libcfs_ioctl.h     |    1 -
> drivers/staging/lustre/lustre/libcfs/module.c      |   17
>-----------------
> 2 files changed, 0 insertions(+), 18 deletions(-)
>
>diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
>b/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
>index f5d741f..485ab26 100644
>--- a/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
>+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
>@@ -110,7 +110,6 @@ struct libcfs_ioctl_handler {
> #define IOC_LIBCFS_CLEAR_DEBUG	     _IOWR('e', 31, long)
> #define IOC_LIBCFS_MARK_DEBUG	      _IOWR('e', 32, long)
> #define IOC_LIBCFS_MEMHOG		  _IOWR('e', 36, long)
>-#define IOC_LIBCFS_PING_TEST	       _IOWR('e', 37, long)
> /* lnet ioctls */
> #define IOC_LIBCFS_GET_NI		  _IOWR('e', 50, long)
> #define IOC_LIBCFS_FAIL_NID		_IOWR('e', 51, long)
>diff --git a/drivers/staging/lustre/lustre/libcfs/module.c
>b/drivers/staging/lustre/lustre/libcfs/module.c
>index 570f05c..89038ed 100644
>--- a/drivers/staging/lustre/lustre/libcfs/module.c
>+++ b/drivers/staging/lustre/lustre/libcfs/module.c
>@@ -274,23 +274,6 @@ static int libcfs_ioctl_int(struct cfs_psdev_file
>  		}
>  		break;
> 
>-	case IOC_LIBCFS_PING_TEST: {
>-		extern void (kping_client)(struct libcfs_ioctl_data *);
>-		void (*ping)(struct libcfs_ioctl_data *);
>-
>-		CDEBUG(D_IOCTL, "doing %d pings to nid %s (%s)\n",
>-		       data->ioc_count, libcfs_nid2str(data->ioc_nid),
>-		       libcfs_nid2str(data->ioc_nid));
>-		ping = symbol_get(kping_client);
>-		if (!ping)
>-			CERROR("symbol_get failed\n");
>-		else {
>-			ping(data);
>-			symbol_put(kping_client);
>-		}
>-		return 0;
>-	}
>-
>  	default: {
>  		struct libcfs_ioctl_handler *hand;
> 
> 
>-- 
>1.7.1


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [lustre-devel] [PATCH v2] staging: lustre: remove IOC_LIBCFS_PING_TEST ioctl
@ 2015-11-27  4:31 ` Dilger, Andreas
  0 siblings, 0 replies; 6+ messages in thread
From: Dilger, Andreas @ 2015-11-27  4:31 UTC (permalink / raw)
  To: lustre-devel

On 2015/11/08, 09:34, "James Simmons" <jsimmons@infradead.org> wrote:

>The ioctl IOC_LIBCFS_PING_TEST has not been used in
>ages. The recent nidstring changes which moved all
>the nidstring operations from libcfs to the LNet
>layer but this ioctl code was still using an
>nidstring operation that was causing an circular
>dependency loop between libcfs and LNet:

Hi Greg,
are you planning on pushing this patch to Linus for 4.4?  It was resent
on 11/08 per your request on 11/07 but I don't see it in staging or
staging-next yet.  Since it fixes the depmod dependency cycle for
allmodconfig builds on mainline it seems worthwhile to include into
4.4-rc3 rather than waiting for 4.5.

Cheers, Andreas


>Signed-off-by: James Simmons <jsimmons@infradead.org>
>---
> .../lustre/include/linux/libcfs/libcfs_ioctl.h     |    1 -
> drivers/staging/lustre/lustre/libcfs/module.c      |   17
>-----------------
> 2 files changed, 0 insertions(+), 18 deletions(-)
>
>diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
>b/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
>index f5d741f..485ab26 100644
>--- a/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
>+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
>@@ -110,7 +110,6 @@ struct libcfs_ioctl_handler {
> #define IOC_LIBCFS_CLEAR_DEBUG	     _IOWR('e', 31, long)
> #define IOC_LIBCFS_MARK_DEBUG	      _IOWR('e', 32, long)
> #define IOC_LIBCFS_MEMHOG		  _IOWR('e', 36, long)
>-#define IOC_LIBCFS_PING_TEST	       _IOWR('e', 37, long)
> /* lnet ioctls */
> #define IOC_LIBCFS_GET_NI		  _IOWR('e', 50, long)
> #define IOC_LIBCFS_FAIL_NID		_IOWR('e', 51, long)
>diff --git a/drivers/staging/lustre/lustre/libcfs/module.c
>b/drivers/staging/lustre/lustre/libcfs/module.c
>index 570f05c..89038ed 100644
>--- a/drivers/staging/lustre/lustre/libcfs/module.c
>+++ b/drivers/staging/lustre/lustre/libcfs/module.c
>@@ -274,23 +274,6 @@ static int libcfs_ioctl_int(struct cfs_psdev_file
>  		}
>  		break;
> 
>-	case IOC_LIBCFS_PING_TEST: {
>-		extern void (kping_client)(struct libcfs_ioctl_data *);
>-		void (*ping)(struct libcfs_ioctl_data *);
>-
>-		CDEBUG(D_IOCTL, "doing %d pings to nid %s (%s)\n",
>-		       data->ioc_count, libcfs_nid2str(data->ioc_nid),
>-		       libcfs_nid2str(data->ioc_nid));
>-		ping = symbol_get(kping_client);
>-		if (!ping)
>-			CERROR("symbol_get failed\n");
>-		else {
>-			ping(data);
>-			symbol_put(kping_client);
>-		}
>-		return 0;
>-	}
>-
>  	default: {
>  		struct libcfs_ioctl_handler *hand;
> 
> 
>-- 
>1.7.1

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] staging: lustre: remove IOC_LIBCFS_PING_TEST ioctl
  2015-11-27  4:31 ` [lustre-devel] " Dilger, Andreas
  (?)
@ 2015-12-21 22:06 ` Greg Kroah-Hartman
  2015-12-21 22:18   ` Linus Torvalds
  -1 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2015-12-21 22:06 UTC (permalink / raw)
  To: Dilger, Andreas
  Cc: devel, James Simmons, Linux Kernel Mailing List, Drokin, Oleg,
	Linus Torvalds, lustre-devel

On Fri, Nov 27, 2015 at 04:31:39AM +0000, Dilger, Andreas wrote:
> On 2015/11/08, 09:34, "James Simmons" <jsimmons@infradead.org> wrote:
> 
> >The ioctl IOC_LIBCFS_PING_TEST has not been used in
> >ages. The recent nidstring changes which moved all
> >the nidstring operations from libcfs to the LNet
> >layer but this ioctl code was still using an
> >nidstring operation that was causing an circular
> >dependency loop between libcfs and LNet:
> 
> Hi Greg,
> are you planning on pushing this patch to Linus for 4.4?  It was resent
> on 11/08 per your request on 11/07 but I don't see it in staging or
> staging-next yet.  Since it fixes the depmod dependency cycle for
> allmodconfig builds on mainline it seems worthwhile to include into
> 4.4-rc3 rather than waiting for 4.5.

No one told me it fixed a bug, let me see if it's still even needed...



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] staging: lustre: remove IOC_LIBCFS_PING_TEST ioctl
  2015-12-21 22:06 ` Greg Kroah-Hartman
@ 2015-12-21 22:18   ` Linus Torvalds
  2015-12-21 22:21     ` Greg Kroah-Hartman
  0 siblings, 1 reply; 6+ messages in thread
From: Linus Torvalds @ 2015-12-21 22:18 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Dilger, Andreas, devel, James Simmons, Linux Kernel Mailing List,
	Drokin, Oleg, lustre-devel

On Mon, Dec 21, 2015 at 2:06 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> No one told me it fixed a bug, let me see if it's still even needed...

You were definitely cc'd on a couple of the threads..

But it's done now (well, two weeks ago), I applied it as commit
d035e336287b ("staging/lustre: remove IOC_LIBCFS_PING_TEST ioctl").

                Linus

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] staging: lustre: remove IOC_LIBCFS_PING_TEST ioctl
  2015-12-21 22:18   ` Linus Torvalds
@ 2015-12-21 22:21     ` Greg Kroah-Hartman
  0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2015-12-21 22:21 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Dilger, Andreas, devel, James Simmons, Linux Kernel Mailing List,
	Drokin, Oleg, lustre-devel

On Mon, Dec 21, 2015 at 02:18:18PM -0800, Linus Torvalds wrote:
> On Mon, Dec 21, 2015 at 2:06 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > No one told me it fixed a bug, let me see if it's still even needed...
> 
> You were definitely cc'd on a couple of the threads..
> 
> But it's done now (well, two weeks ago), I applied it as commit
> d035e336287b ("staging/lustre: remove IOC_LIBCFS_PING_TEST ioctl").

Ah, see it now, sorry about that, catching up on old staging patches
right now...

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH v2] staging: lustre: remove IOC_LIBCFS_PING_TEST ioctl
@ 2015-11-08 16:34 James Simmons
  0 siblings, 0 replies; 6+ messages in thread
From: James Simmons @ 2015-11-08 16:34 UTC (permalink / raw)
  To: Greg Kroah-Hartman, devel, Oleg Drokin, Andreas Dilger
  Cc: Linux Kernel Mailing List, lustre-devel, James Simmons

The ioctl IOC_LIBCFS_PING_TEST has not been used in
ages. The recent nidstring changes which moved all
the nidstring operations from libcfs to the LNet
layer but this ioctl code was still using an
nidstring operation that was causing an circular
dependency loop between libcfs and LNet.

Signed-off-by: James Simmons <jsimmons@infradead.org>
---
 .../lustre/include/linux/libcfs/libcfs_ioctl.h     |    1 -
 drivers/staging/lustre/lustre/libcfs/module.c      |   17 -----------------
 2 files changed, 0 insertions(+), 18 deletions(-)

diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h b/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
index f5d741f..485ab26 100644
--- a/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h
@@ -110,7 +110,6 @@ struct libcfs_ioctl_handler {
 #define IOC_LIBCFS_CLEAR_DEBUG	     _IOWR('e', 31, long)
 #define IOC_LIBCFS_MARK_DEBUG	      _IOWR('e', 32, long)
 #define IOC_LIBCFS_MEMHOG		  _IOWR('e', 36, long)
-#define IOC_LIBCFS_PING_TEST	       _IOWR('e', 37, long)
 /* lnet ioctls */
 #define IOC_LIBCFS_GET_NI		  _IOWR('e', 50, long)
 #define IOC_LIBCFS_FAIL_NID		_IOWR('e', 51, long)
diff --git a/drivers/staging/lustre/lustre/libcfs/module.c b/drivers/staging/lustre/lustre/libcfs/module.c
index 570f05c..89038ed 100644
--- a/drivers/staging/lustre/lustre/libcfs/module.c
+++ b/drivers/staging/lustre/lustre/libcfs/module.c
@@ -274,23 +274,6 @@ static int libcfs_ioctl_int(struct cfs_psdev_file *pfile, unsigned long cmd,
 		}
 		break;
 
-	case IOC_LIBCFS_PING_TEST: {
-		extern void (kping_client)(struct libcfs_ioctl_data *);
-		void (*ping)(struct libcfs_ioctl_data *);
-
-		CDEBUG(D_IOCTL, "doing %d pings to nid %s (%s)\n",
-		       data->ioc_count, libcfs_nid2str(data->ioc_nid),
-		       libcfs_nid2str(data->ioc_nid));
-		ping = symbol_get(kping_client);
-		if (!ping)
-			CERROR("symbol_get failed\n");
-		else {
-			ping(data);
-			symbol_put(kping_client);
-		}
-		return 0;
-	}
-
 	default: {
 		struct libcfs_ioctl_handler *hand;
 
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-12-21 22:22 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-27  4:31 [PATCH v2] staging: lustre: remove IOC_LIBCFS_PING_TEST ioctl Dilger, Andreas
2015-11-27  4:31 ` [lustre-devel] " Dilger, Andreas
2015-12-21 22:06 ` Greg Kroah-Hartman
2015-12-21 22:18   ` Linus Torvalds
2015-12-21 22:21     ` Greg Kroah-Hartman
  -- strict thread matches above, loose matches on Subject: below --
2015-11-08 16:34 James Simmons

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.