All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/8 RFC] core: install foo-config scripts early in the PATH (branch yem/foo-config-in-PATH)
Date: Mon, 21 Dec 2015 23:20:48 +0100	[thread overview]
Message-ID: <20151221232048.1218dd26@free-electrons.com> (raw)
In-Reply-To: <cover.1450712392.git.yann.morin.1998@free.fr>

Yann,

On Mon, 21 Dec 2015 16:56:55 +0100, Yann E. MORIN wrote:

> This RFC series is an attempt at solving once and for all the problem we
> encounter with foo-config scripts.
> 
> The foo-config scripts are usually installed in staging, so are out of
> the PATH. However, most packages will just simply want to run them, and
> most are not configurable in where to look for that script and just
> expect to find them in the PATH.
> 
> Up until now, we used to patch those packages so that they accept an
> environment variable.
> 
> Arnout has suggested [0] that we move all the target-related foo-config
> scripts early in the PATH, so that they are found before the host ones
> and before the system ones.
> 
> This would allow us to drop our local patches, and to no longer set the
> custom FOO_CONFIG or the ac_cv_foo_config variables from our package
> recipes.

Unfortunately, I believe it doesn't work completely, because there are
some <foo>-config scripts that are not listed in <pkg>_CONFIG_SCRIPTS
because they are for some reason not compatible with the fixup that we
do. One example that comes to mind is python-*config (they are written
in shell but don't follow the usual pattern). I believe there might be
other cases as well.

Also, this solution doesn't solve the (admittedly unlikely) case of a
package calling /usr/bin/<foo>-config directly.

But I agree that it might solve many of the usual cases. I don't know
if the additional complexity of yet another special mechanism really
makes it worth it. I'd like to hear from Peter about this.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-12-21 22:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-21 15:56 [Buildroot] [PATCH 0/8 RFC] core: install foo-config scripts early in the PATH (branch yem/foo-config-in-PATH) Yann E. MORIN
2015-12-21 15:56 ` [Buildroot] [PATCH 1/8 RFC] core: split long line of directories Yann E. MORIN
2015-12-21 15:56 ` [Buildroot] [PATCH 2/8 RFC] core/pkg-generic: use a $(foreach) loop to fix foo-config scripts Yann E. MORIN
2015-12-21 15:56 ` [Buildroot] [PATCH 3/8 RFC] core/pkg-generic: install foo-config scripts in their own dir Yann E. MORIN
2015-12-21 18:51   ` Baruch Siach
2015-12-21 20:50     ` Yann E. MORIN
2015-12-21 15:56 ` [Buildroot] [PATCH 4/8 RFC] core: re-instate different target and host PATHs Yann E. MORIN
2015-12-21 15:56 ` [Buildroot] [PATCH 5/8 RFC] fs: use HOST_PATH Yann E. MORIN
2015-12-21 15:56 ` [Buildroot] [PATCH 6/8 RFC] packages: " Yann E. MORIN
2015-12-21 15:56 ` [Buildroot] [PATCH 7/8 RFC] packages: use TARGET_PATH Yann E. MORIN
2015-12-21 18:44   ` Baruch Siach
2015-12-21 20:46     ` Yann E. MORIN
2015-12-21 15:56 ` [Buildroot] [PATCH 8/8 RFC] package/libhid: no need for custom PATH Yann E. MORIN
2015-12-21 22:20 ` Thomas Petazzoni [this message]
2015-12-21 22:30   ` [Buildroot] [PATCH 0/8 RFC] core: install foo-config scripts early in the PATH (branch yem/foo-config-in-PATH) Yann E. MORIN
2015-12-21 22:34     ` Thomas Petazzoni
2015-12-21 22:55       ` Yann E. MORIN
2015-12-22 10:53         ` Thomas Petazzoni
2015-12-22 11:06           ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151221232048.1218dd26@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.