From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v5 3/5] PCI: qcom: Add Qualcomm PCIe controller driver Date: Tue, 22 Dec 2015 00:04:22 +0100 Message-ID: <201512220004.22548.arnd@arndb.de> References: <1450442339-18765-4-git-send-email-stanimir.varbanov@linaro.org> <201512182111.1GLn2hxy%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mout.kundenserver.de ([217.72.192.75]:52557 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751598AbbLUXFk (ORCPT ); Mon, 21 Dec 2015 18:05:40 -0500 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Bjorn Andersson Cc: kbuild test robot , Stanimir Varbanov , kbuild-all@01.org, linux-arm-msm , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , linux-pci@vger.kernel.org, Bjorn Helgaas , Srinivas Kandagatla , Russell King , Rob Herring , Rob Herring , Mark Rutland , Pawel Moll , Ian Campbell , Jingoo Han , Pratyush Anand , Bjorn Andersson , Stanimir Varbanov On Monday 21 December 2015, Bjorn Andersson wrote: > I disagree with this "recommendation" as it's only outcome will be asymmetry. > > I think this script should be changed to only warn if there's a single > IS_ERR/PTR_ERR at the end of the function, not if there's a list of > them and this would replace the last one. > Agreed, looks like a false positive, and I think it's best to ignore the warning here, but not change the script that seems reasonable in general. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752609AbbLUXFm (ORCPT ); Mon, 21 Dec 2015 18:05:42 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:52557 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751598AbbLUXFk (ORCPT ); Mon, 21 Dec 2015 18:05:40 -0500 From: Arnd Bergmann To: Bjorn Andersson Subject: Re: [PATCH v5 3/5] PCI: qcom: Add Qualcomm PCIe controller driver Date: Tue, 22 Dec 2015 00:04:22 +0100 User-Agent: KMail/1.12.2 (Linux/3.19.0-27-generic; KDE/4.3.2; x86_64; ; ) Cc: kbuild test robot , Stanimir Varbanov , kbuild-all@01.org, "linux-arm-msm" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , linux-pci@vger.kernel.org, Bjorn Helgaas , Srinivas Kandagatla , Russell King , Rob Herring , Rob Herring , Mark Rutland , Pawel Moll , Ian Campbell , Jingoo Han , Pratyush Anand , Bjorn Andersson , Stanimir Varbanov References: <1450442339-18765-4-git-send-email-stanimir.varbanov@linaro.org> <201512182111.1GLn2hxy%fengguang.wu@intel.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201512220004.22548.arnd@arndb.de> X-Provags-ID: V03:K0:AkcZoVjQw12i5Q8BNFylnpv+7jAFKaW9dHmJkQzWuTovQtIfOmt yC8Y6JNvqjeJpM1E3a9+x6w7DNVHEl/MJJucJ18/CU0BPj6rd5ug1h3yp2kfov2JJgLS65O 4ZtmRNI7bFaqQa+68gZuOA46Oo4JuhYPHnWCAmpDu14lXdWoVeAtqSXUrWHqWqDFc9f2Viw UZeGkMT7R0mMx8ZeIu07g== X-UI-Out-Filterresults: notjunk:1;V01:K0:Vz+H7KOiEIE=:FhAsz/sXecurdlPxj/fXJ5 wpwiMmA7+Onu08/ohXwOGlfmThsdWfigWwq8bfn3FDMfGA/EkNi/zx0mlRWrnT0X2/yJkWMt9 RbgI0b0OdEWwxmopXan4iGf7LD/JrrpCwMPjpTiQdu8G22EW1mKRLENoX4ydNNEt6swbrl7si TeQLzvRNHjn4IQCs9BsZdqTsd2gO5c61bAwKH5ayRGR5tqGUiltf7vSDDOxmAPfqn20Mi256/ HFwW4uHUe3xw7ptDkKgpKIs3KJQ5tgfbLMMp3iLrmNJ0BKmwYonW2/O6lkFam233c8iNl5rWV IdPk/7E6gNodeiaiqtwe3aTds/4gygHb2/Ww0KN2/KQ9rJWYytG1joxSKmMh0/wf/BKv4pCXh l1JKoPlW67f7WQ7dtozqg3TK7xdVMZ+sB8LL+i0GQUV5CeA2YBxPMh9CkUbd7ayvkicWrzKo4 lB/wkk5VPocKlhxrYp4oZRihFSCTtYN/6KBspEmo1f/s65OGvPSrqATnMzZedv9RCuPhYv+aa qMnhf1lEL6sqW2CUc+eeNZwimTaDR9dup1+CkU7nWEzNfEFn5CZeHycMtGDN59RDOZ1ifG6mr bVapLmhbrYOyuCoOT9wErkP2J/03wWPe6DhEZxq4orCSUURKwn+6+Z17kFahbfDoiC8vvygQv MxoDTOj+oDaQSzpQfkcfJ4Owa1xo8vXi+/Cj/+Ydg6nNKMVi2Yt/mQc2ReqvZm52XR/pfv4lM /ycJHRb+jYMwllwF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 21 December 2015, Bjorn Andersson wrote: > I disagree with this "recommendation" as it's only outcome will be asymmetry. > > I think this script should be changed to only warn if there's a single > IS_ERR/PTR_ERR at the end of the function, not if there's a list of > them and this would replace the last one. > Agreed, looks like a false positive, and I think it's best to ignore the warning here, but not change the script that seems reasonable in general. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 22 Dec 2015 00:04:22 +0100 Subject: [PATCH v5 3/5] PCI: qcom: Add Qualcomm PCIe controller driver In-Reply-To: References: <1450442339-18765-4-git-send-email-stanimir.varbanov@linaro.org> <201512182111.1GLn2hxy%fengguang.wu@intel.com> Message-ID: <201512220004.22548.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 21 December 2015, Bjorn Andersson wrote: > I disagree with this "recommendation" as it's only outcome will be asymmetry. > > I think this script should be changed to only warn if there's a single > IS_ERR/PTR_ERR at the end of the function, not if there's a list of > them and this would replace the last one. > Agreed, looks like a false positive, and I think it's best to ignore the warning here, but not change the script that seems reasonable in general. Arnd