From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933263AbbLVQIt (ORCPT ); Tue, 22 Dec 2015 11:08:49 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:46188 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932402AbbLVQIp (ORCPT ); Tue, 22 Dec 2015 11:08:45 -0500 Date: Tue, 22 Dec 2015 16:08:30 +0000 From: Mark Brown To: chenfeng Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, xuwei5@hisilicon.com, puck.chen@aliyun.com, yudongbin@hisilicon.com, saberlily.xia@hisilicon.com, suzhuangluan@hisilicon.com, kong.kongxinwei@hisilicon.com, xuyiping@hisilicon.com, z.liuxinliang@hisilicon.com, weidong2@hisilicon.com, w.f@huawei.com, qijiwen@hisilicon.com, peter.panshilin@hisilicon.com, dan.zhao@hisilicon.com, linuxarm@huawei.com Message-ID: <20151222160830.GA16023@sirena.org.uk> References: <1450184056-79851-1-git-send-email-puck.chen@hisilicon.com> <1450184056-79851-6-git-send-email-puck.chen@hisilicon.com> <56722B9F.8090301@hisilicon.com> <20151218175813.GE5727@sirena.org.uk> <56776B91.3030004@hisilicon.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9amGYk9869ThD9tj" Content-Disposition: inline In-Reply-To: <56776B91.3030004@hisilicon.com> X-Cookie: Honk if you love peace and quiet. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:808::2 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --9amGYk9869ThD9tj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 21, 2015 at 11:01:37AM +0800, chenfeng wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > I see, I will change the table of voltages into driver. > like this, > static const unsigned int voltages[] = { > 1500000, 1800000, 2400000, 2500000, > 2600000, 2700000, 2850000, 3000000, > }; > And there will be two open-code function for is-enable and disable in the regulator driver. > Since we need use the status and disable register on PM chip. Only enable reg in the regulator desc. > Do you agree with this? Yes. --9amGYk9869ThD9tj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWeXV9AAoJECTWi3JdVIfQ92QIAITZnLWSagJHPQyR3OqQKdcu 2NK858/K4PM00+vatW9aJx5jR4d35s2ur3pYbD/N7tyyfPApxIYtuGNOJQLx+XUX dqEJ3+LlfRKdoSWlB1WRPanZzePr0f2LSxo/ABmxNkUhIjmE3IwyYAqEibjXHrwA djkbrvDg4axZOVvdjM5+uhoaYvZS2HTm/lXDBNLfgZwxK9RcLQEuAkrU7k/0dq6c xaVi/eTVxI26aXPa4opnl4Xmib3ym4I2hFPwgRrRPayLlsDDNvPUPjm4/+sQ40qv me8E89JSRK8OI2fNSPjCKpcUhIa7X0UqVhSQ77F8VnMFI8viGd2f3kFrTZVJrRI= =+RKd -----END PGP SIGNATURE----- --9amGYk9869ThD9tj--