From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755592AbbLVRMI (ORCPT ); Tue, 22 Dec 2015 12:12:08 -0500 Received: from foss.arm.com ([217.140.101.70]:54863 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753399AbbLVRMF (ORCPT ); Tue, 22 Dec 2015 12:12:05 -0500 Date: Tue, 22 Dec 2015 17:11:59 +0000 From: Catalin Marinas To: Yury Norov Cc: arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pinskia@gmail.com, Prasun.Kapoor@caviumnetworks.com, schwab@suse.de, broonie@kernel.org, Nathan_Lynch@mentor.com, agraf@suse.de, klimov.linux@gmail.com, jan.dakinevich@gmail.com, ddaney.cavm@gmail.com, bamvor.zhangjian@huawei.com, philipp.tomsich@theobroma-systems.com, joseph@codesourcery.com, christoph.muellner@theobroma-systems.com Subject: Re: [PATCH v6 15/20] arm64: signal: move ilp32 and lp64 common code to separated file Message-ID: <20151222171158.GD1302@e104818-lin.cambridge.arm.com> References: <1450215766-14765-1-git-send-email-ynorov@caviumnetworks.com> <1450215766-14765-16-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450215766-14765-16-git-send-email-ynorov@caviumnetworks.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 16, 2015 at 12:42:41AM +0300, Yury Norov wrote: > After that, it will be possible to reuse it in ILP32. > > Signed-off-by: Yury Norov > --- > arch/arm64/include/asm/signal_common.h | 39 ++++++++ > arch/arm64/kernel/Makefile | 2 +- > arch/arm64/kernel/signal.c | 154 +---------------------------- > arch/arm64/kernel/signal_common.c | 174 +++++++++++++++++++++++++++++++++ signal.c is always compiled, so I don't see the point of a signal_common.c, just export the functions from signal.c (signal32_common.c is a different story since we may not always compile AArch32 support in). -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 From: catalin.marinas@arm.com (Catalin Marinas) Date: Tue, 22 Dec 2015 17:11:59 +0000 Subject: [PATCH v6 15/20] arm64: signal: move ilp32 and lp64 common code to separated file In-Reply-To: <1450215766-14765-16-git-send-email-ynorov@caviumnetworks.com> References: <1450215766-14765-1-git-send-email-ynorov@caviumnetworks.com> <1450215766-14765-16-git-send-email-ynorov@caviumnetworks.com> Message-ID: <20151222171158.GD1302@e104818-lin.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Dec 16, 2015 at 12:42:41AM +0300, Yury Norov wrote: > After that, it will be possible to reuse it in ILP32. > > Signed-off-by: Yury Norov > --- > arch/arm64/include/asm/signal_common.h | 39 ++++++++ > arch/arm64/kernel/Makefile | 2 +- > arch/arm64/kernel/signal.c | 154 +---------------------------- > arch/arm64/kernel/signal_common.c | 174 +++++++++++++++++++++++++++++++++ signal.c is always compiled, so I don't see the point of a signal_common.c, just export the functions from signal.c (signal32_common.c is a different story since we may not always compile AArch32 support in). -- Catalin