Re: [PATCH 07/10] drm/i915: Support for pread/pwrite from/to non shmem backed objects

From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: ankitprasad.r.sharma@intel.com, intel-gfx@lists.freedesktop.org,
	akash.goel@intel.com, shashidhar.hiremath@intel.com
Subject: Re: [PATCH 07/10] drm/i915: Support for pread/pwrite from/to non shmem backed objects
Date: Tue, 22 Dec 2015 17:40:09 +0000	[thread overview]
Message-ID: <20151222174009.GI5896@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <56793AE9.5090300@linux.intel.com>

On Tue, Dec 22, 2015 at 11:58:33AM +0000, Tvrtko Ursulin wrote:
> Maybe:
> 
> 	if (!obj->base.filp || cpu_write_needs_clflush(obj))
>    		ret = i915_gem_gtt_pwrite_fast(...);
> 
> 	if (ret == -EFAULT && !obj->base.filp) {
> 		ret = i915_gem_gtt_pwrite_slow(...) /* New function, doing the
> slow_user_access loop for !filp objects, extracted from
> gtt_pwrite_fast above. */

The point is that "gtt_pwrite_slow" is going to be preferrable in the
cases where it is possible. It just wasn't the full fallback patch for
all objects previously, so we didn't bother to write a partial fallback
handler.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx