From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933447AbbLVT2G (ORCPT ); Tue, 22 Dec 2015 14:28:06 -0500 Received: from down.free-electrons.com ([37.187.137.238]:37179 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752261AbbLVT2D (ORCPT ); Tue, 22 Dec 2015 14:28:03 -0500 Date: Tue, 22 Dec 2015 20:27:51 +0100 From: Alexandre Belloni To: Sasha Levin Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux-next: build failure after merge of the rtc tree Message-ID: <20151222192751.GG8623@piout.net> References: <20151217160344.096b4a9e@canb.auug.org.au> <20151217112154.GE13078@piout.net> <5674268E.508@oracle.com> <20151218164341.GB3541@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151218164341.GB3541@piout.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sasha, On 18/12/2015 at 17:43:41 +0100, Alexandre Belloni wrote : > > > Sasha, I think I prefer having 32 bit platforms fail on the 21st of > > > January 11761191 rather than adding more uses of do_div in the function. > > > I'll have a look at the performance impact on 32 bit platforms. > > > > I'm really fine with just adding a WARN_ON() and aborting if it's the year > > 11761191 :) > > > > One simple way to solve it for 64bit platforms is to define days as > unsigned long. Maybe throw a comment that it will fail for 32bit > platforms in January 11761191 ;). > I did that: http://git.kernel.org/cgit/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next&id=0d3da1806b985f1100615c2c09033b404941b63e Unless you disagree, that is what I'm planning to send to Linus. I wish you a happy end of year. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com