From mboxrd@z Thu Jan 1 00:00:00 1970 From: Faisal Latif Subject: Re: [PATCH V1 00/16] add Intel(R) X722 iWARP driver Date: Wed, 23 Dec 2015 10:35:49 -0600 Message-ID: <20151223163549.GA22244@flatif-MOBL1> References: <1450739596-23276-1-git-send-email-faisal.latif@intel.com> <567AC754.5020508@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <567AC754.5020508-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Ledford Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jeffrey.t.kirsher-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Wed, Dec 23, 2015 at 11:09:56AM -0500, Doug Ledford wrote: > On 12/21/2015 06:13 PM, Faisal Latif wrote: > > This (V1) series contains the addition of the i40iw.ko driver after > > incorporating the feedback from Christoph Hellwig and Joe Perches for > > initial series. > > > > This driver provides iWARP RDMA functionality for the Intel(R) X722 Ethernet > > controller for PCI Physical Functions. It also has support for Virtual > > Function driver (i40iwvf.ko), which that will be part of separate patch > > series. > > > > It cooperates with the Intel(R) X722 base driver (i40e.ko) to allocate > > resources and program the controller. > > > > This series include 1 patch to i40e.ko to provide interface support to > > i40iw.ko. The interface provides a driver registration mechanism, resource > > allocations, and device reset coordination mechanisms. > > > > This patch series is based on Doug Ledford's k.o/for-4.5. > > My apologies Faisal. I had pushed that branch to github to get 0-day > testing, but hadn't committed it to my k.o tree as it wasn't fully > finalized (I was waiting for Or to get his chance to respond to it). > Once Or responded, I ended up taking his patchset instead, which means > you need to adjust your patches accordingly. > Thanks Doug for the update, I will provide new patch series for latest k.o. Also will make sure of shallow threading for the series. I should have used V2 for this series instead of V1 and next series with k.o will make it proper with V3. > > > > Anjali Singhai Jain (1) > > net/ethernet/intel/i40e: Add support for client interface for IWARP driver > > > > Faisal Latif(15): > > infiniband/hw/i40iw: add main, hdr, status > > infiniband/hw/i40iw: add connection management code > > infiniband/hw/i40iw: add puda code > > infiniband/hw/i40iw: add pble resource files > > infiniband/hw/i40iw: add hmc resource files > > infiniband/hw/i40iw: add hw and utils files > > infiniband/hw/i40iw: add files for iwarp interface > > infiniband/hw/i40iw: add file to handle cqp calls > > infiniband/hw/i40iw: add hardware related header files > > infiniband/hw/i40iw: add X722 register file > > infiniband/hw/i40iw: user kernel shared files > > infiniband/hw/i40iw: virtual channel handling files > > infiniband/hw/i40iw: Kconfig and Kbuild for iwarp module > > infiniband/hw/i40iw: Add entry for I40IW rdma_netlink.h > > infiniband/hw/i40iw: changes for build of i40iw module > > > > Changes done from initial version to V1 are following. > > > > Feedback received from Christoph Hellwig > > *Remove pointless braces -improved after code review and changing > > *kmap()/kunmap() - made it very short lived > > *less casts -improved > > *Remove unused routine stubs - done > > *no initialize to 0 or NULL when struct field were zeroed - done > > *define UNREFERENCED_PARAMETER not needed -done > > *remove define I40eE_MASK -done > > *rd32(), wr32() make them inline -done > > *readq() use magic in linux/io-64-nonatomic-lo-hi.h -done > > *SLEEP() define -done by removing it > > *entry in rdma_netlink.h for I40IW should be in proper location > > and separate patch -done > > > > Feedback received from Joe Perches > > *series to respuun re-spun against next - done with > > Doug's Ledford's k.o/for-4.5 > > *Change to i40e client patch regarding mailing list - this is consistent > > with other i40e files. > > *Removed error from i40iw_pr_err() -done > > *cqp_request() change from bitfields to bool -done > > > > > -- > Doug Ledford > GPG KeyID: 0E572FDD > > Faisal -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html