From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752798AbbLXOWS (ORCPT ); Thu, 24 Dec 2015 09:22:18 -0500 Received: from tex.lwn.net ([70.33.254.29]:34222 "EHLO vena.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751248AbbLXOWQ (ORCPT ); Thu, 24 Dec 2015 09:22:16 -0500 Date: Thu, 24 Dec 2015 07:22:10 -0700 From: Jonathan Corbet To: SF Markus Elfring Cc: linux-doc@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 1/3] Documentation-getdelays: Fix a check for container file usage in main() Message-ID: <20151224072210.15d6ee6c@lwn.net> In-Reply-To: <567BE64C.4090604@users.sourceforge.net> References: <566ABCD9.1060404@users.sourceforge.net> <567BE5AA.6070607@users.sourceforge.net> <567BE64C.4090604@users.sourceforge.net> Organization: LWN.net X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Dec 2015 13:34:20 +0100 SF Markus Elfring wrote: > The close() function could be called by the main() function even if > the passed variable "cfd" was assigned a negative value. > > * Corresponding implementation details could be improved by adjustments > for jump targets according to the Linux coding style convention. > > * Fix the affected condition check. This seems more easily fixed by simply making the condition > 0. Meanwhile, I'd really not add labels-inside-if-statements as an example in the documentation tree. Thanks, jon From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Corbet Date: Thu, 24 Dec 2015 14:22:10 +0000 Subject: Re: [PATCH 1/3] Documentation-getdelays: Fix a check for container file usage in main() Message-Id: <20151224072210.15d6ee6c@lwn.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <567BE5AA.6070607@users.sourceforge.net> <567BE64C.4090604@users.sourceforge.net> In-Reply-To: <567BE64C.4090604@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: linux-doc@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Thu, 24 Dec 2015 13:34:20 +0100 SF Markus Elfring wrote: > The close() function could be called by the main() function even if > the passed variable "cfd" was assigned a negative value. > > * Corresponding implementation details could be improved by adjustments > for jump targets according to the Linux coding style convention. > > * Fix the affected condition check. This seems more easily fixed by simply making the condition > 0. Meanwhile, I'd really not add labels-inside-if-statements as an example in the documentation tree. Thanks, jon