From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34904)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aCHbO-0001Ts-L6
	for qemu-devel@nongnu.org; Thu, 24 Dec 2015 20:55:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aCHbN-0007op-RL
	for qemu-devel@nongnu.org; Thu, 24 Dec 2015 20:55:30 -0500
Date: Fri, 25 Dec 2015 09:55:22 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20151225015522.GB26066@ad.usersys.redhat.com>
References: <1450867706-19860-3-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1450867706-19860-3-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block: add missing call to
 bdrv_drain_recurse
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org

On Wed, 12/23 11:48, Paolo Bonzini wrote:
> This is also needed in bdrv_drain_all, not just in bdrv_drain.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  block/io.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/block/io.c b/block/io.c
> index 841f5b5..bfe2544 100644
> --- a/block/io.c
> +++ b/block/io.c
> @@ -293,6 +293,7 @@ void bdrv_drain_all(void)
>          if (bs->job) {
>              block_job_pause(bs->job);
>          }
> +        bdrv_drain_recurse(bs);
>          aio_context_release(aio_context);
>  
>          if (!g_slist_find(aio_ctxs, aio_context)) {
> -- 
> 2.5.0
> 
> 

Reviewed-by: Fam Zheng <famz@redhat.com>