All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libasplib: new package
Date: Mon, 28 Dec 2015 22:06:55 +0100	[thread overview]
Message-ID: <20151228220655.64e381c1@free-electrons.com> (raw)
In-Reply-To: <1450647112-17364-1-git-send-email-bernd.kuhls@t-online.de>

Dear Bernd Kuhls,

On Sun, 20 Dec 2015 22:31:52 +0100, Bernd Kuhls wrote:
> Needed for upcoming kodi-adsp-biquad-filters package
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/Config.in                                  |  1 +
>  .../0001-Fix-linux-detection-with-buildroot.patch  | 31 ++++++++++++++++++++++
>  package/libasplib/Config.in                        | 11 ++++++++
>  package/libasplib/libasplib.mk                     | 13 +++++++++
>  4 files changed, 56 insertions(+)
>  create mode 100644 package/libasplib/0001-Fix-linux-detection-with-buildroot.patch
>  create mode 100644 package/libasplib/Config.in
>  create mode 100644 package/libasplib/libasplib.mk

I applied, after doing two changes:
 
 - Adding a dependency on i386 || x86-64. Indeed the source code uses
   <cpuid.h>, which is only provided on these architectures. In
   general, it would be good if you could test build the new packages
   on at least one non-x86 architecture, since it typically allows to
   uncover some cross-compilation issues or other x86 specificities.

 - Added a hash file, since we now add hash files for packages sourced
   from github.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2015-12-28 21:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-20 21:31 [Buildroot] [PATCH 1/1] package/libasplib: new package Bernd Kuhls
2015-12-28 21:06 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151228220655.64e381c1@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.