From: Stephen Hemminger <stephen@networkplumber.org>
To: Zhihong Wang <zhihong.wang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v5 2/3] examples/l2fwd: Handle SIGINT and SIGTERM in l2fwd
Date: Thu, 31 Dec 2015 09:01:53 -0800 [thread overview]
Message-ID: <20151231090153.5f64ddc2@xeon-e3> (raw)
In-Reply-To: <1451512791-5442-3-git-send-email-zhihong.wang@intel.com>
On Wed, 30 Dec 2015 16:59:50 -0500
Zhihong Wang <zhihong.wang@intel.com> wrote:
> +static void
> +signal_handler(int signum)
> +{
> + if (signum == SIGINT || signum == SIGTERM) {
> + printf("\n\nSignal %d received, preparing to exit...\n",
> + signum);
> + force_quit = true;
Actually, the if () is redundant since you only registered SIGINT, and SIGTERM those are the
only signals you could possibly receive.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2015-12-31 17:01 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-25 2:37 [PATCH v2 0/3] Handle SIGINT and SIGTERM in DPDK examples Zhihong Wang
2015-12-25 2:37 ` [PATCH v2 1/3] app/test-pmd: Handle SIGINT and SIGTERM in testpmd Zhihong Wang
2015-12-27 21:42 ` Stephen Hemminger
2015-12-28 1:37 ` Wang, Zhihong
2015-12-25 2:37 ` [PATCH v2 2/3] examples/l2fwd: Handle SIGINT and SIGTERM in l2fwd Zhihong Wang
2015-12-27 21:49 ` Stephen Hemminger
2015-12-28 1:35 ` Wang, Zhihong
2015-12-25 2:37 ` [PATCH v2 3/3] examples/l3fwd: Handle SIGINT and SIGTERM in l3fwd Zhihong Wang
2015-12-28 4:17 ` [PATCH v2 0/3] Handle SIGINT and SIGTERM in DPDK examples Qiu, Michael
2015-12-28 9:51 ` Wang, Zhihong
2015-12-29 1:20 ` [PATCH v3 " Zhihong Wang
2015-12-29 1:20 ` [PATCH v3 1/3] app/test-pmd: Handle SIGINT and SIGTERM in testpmd Zhihong Wang
2015-12-29 1:20 ` [PATCH v3 2/3] examples/l2fwd: Handle SIGINT and SIGTERM in l2fwd Zhihong Wang
2015-12-30 17:35 ` Stephen Hemminger
2015-12-29 1:20 ` [PATCH v3 3/3] examples/l3fwd: Handle SIGINT and SIGTERM in l3fwd Zhihong Wang
2015-12-29 13:34 ` Ananyev, Konstantin
2015-12-30 3:15 ` Wang, Zhihong
2015-12-30 11:29 ` Ananyev, Konstantin
2015-12-31 2:14 ` Wang, Zhihong
2015-12-30 17:37 ` Stephen Hemminger
2015-12-29 23:27 ` [PATCH v4 0/3] Handle SIGINT and SIGTERM in DPDK examples Zhihong Wang
2015-12-29 23:27 ` [PATCH v4 1/3] app/test-pmd: Handle SIGINT and SIGTERM in testpmd Zhihong Wang
2015-12-29 23:27 ` [PATCH v4 2/3] examples/l2fwd: Handle SIGINT and SIGTERM in l2fwd Zhihong Wang
2015-12-29 23:27 ` [PATCH v4 3/3] examples/l3fwd: Handle SIGINT and SIGTERM in l3fwd Zhihong Wang
2015-12-30 13:37 ` Ananyev, Konstantin
2015-12-31 1:44 ` Wang, Zhihong
2015-12-31 2:09 ` Stephen Hemminger
2015-12-31 2:20 ` Wang, Zhihong
2015-12-30 21:59 ` [PATCH v5 0/3] Handle SIGINT and SIGTERM in DPDK examples Zhihong Wang
2015-12-30 21:59 ` [PATCH v5 1/3] app/test-pmd: Handle SIGINT and SIGTERM in testpmd Zhihong Wang
2015-12-30 21:59 ` [PATCH v5 2/3] examples/l2fwd: Handle SIGINT and SIGTERM in l2fwd Zhihong Wang
2015-12-31 17:01 ` Stephen Hemminger [this message]
2016-01-04 2:00 ` Wang, Zhihong
2015-12-30 21:59 ` [PATCH v5 3/3] examples/l3fwd: Handle SIGINT and SIGTERM in l3fwd Zhihong Wang
2016-01-06 13:51 ` Ananyev, Konstantin
2016-01-27 16:34 ` [PATCH v5 0/3] Handle SIGINT and SIGTERM in DPDK examples Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151231090153.5f64ddc2@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.