From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751956AbcACR6V (ORCPT ); Sun, 3 Jan 2016 12:58:21 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:56434 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbcACR6S (ORCPT ); Sun, 3 Jan 2016 12:58:18 -0500 Date: Sun, 3 Jan 2016 09:58:16 -0800 From: Greg Kroah-Hartman To: SF Markus Elfring Cc: Julia Lawall , devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, LKML , Lior Dotan , Christopher Harrer Subject: Re: [PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init() Message-ID: <20160103175816.GA21611@kroah.com> References: <566ABCD9.1060404@users.sourceforge.net> <56894D2D.1010801@users.sourceforge.net> <56895EE1.7080808@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56895EE1.7080808@users.sourceforge.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 03, 2016 at 06:48:17PM +0100, SF Markus Elfring wrote: > >> Replace explicit initialisation for two local variables at the beginning > >> by assignments. > > > > Why? > > I prefer that assignments for variables like "card" and "slic_regs" > will only be performed immediately before the corresponding content will be > read again (after a few condition checks were executed). > > Another description could be this view: > I suggest to move the variable initialisation a bit. And like David Miller and others just said, please don't bother us with pointless patches such as this, if you keep it up, I'll have to add you to my killfile as patches like this are a waste of everyone's valuable time. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Sun, 03 Jan 2016 17:58:16 +0000 Subject: Re: [PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init() Message-Id: <20160103175816.GA21611@kroah.com> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <56894D2D.1010801@users.sourceforge.net> <56895EE1.7080808@users.sourceforge.net> In-Reply-To: <56895EE1.7080808@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: Julia Lawall , devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, LKML , Lior Dotan , Christopher Harrer On Sun, Jan 03, 2016 at 06:48:17PM +0100, SF Markus Elfring wrote: > >> Replace explicit initialisation for two local variables at the beginning > >> by assignments. > > > > Why? > > I prefer that assignments for variables like "card" and "slic_regs" > will only be performed immediately before the corresponding content will be > read again (after a few condition checks were executed). > > Another description could be this view: > I suggest to move the variable initialisation a bit. And like David Miller and others just said, please don't bother us with pointless patches such as this, if you keep it up, I'll have to add you to my killfile as patches like this are a waste of everyone's valuable time. greg k-h