From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752580AbcADB00 (ORCPT ); Sun, 3 Jan 2016 20:26:26 -0500 Received: from mail-pa0-f50.google.com ([209.85.220.50]:36763 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751894AbcADB0Q (ORCPT ); Sun, 3 Jan 2016 20:26:16 -0500 Date: Mon, 4 Jan 2016 10:25:28 +0900 From: Namhyung Kim To: Marcin =?utf-8?Q?=C5=9Alusarz?= Cc: LKML , Arnaldo Carvalho de Melo Subject: Re: [PATCH] perf tools: handle spaces in file names obtained from /proc/pid/maps Message-ID: <20160104012528.GA5950@danjae.kornet> References: <20160101030321.GA2217@marcin-Inspiron-7720> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160101030321.GA2217@marcin-Inspiron-7720> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marcin, On Fri, Jan 01, 2016 at 04:03:21AM +0100, Marcin Ślusarz wrote: > Steam frequently puts game binaries in folders with spaces. > > Note: "(deleted)" markers are now treated as part of the file name. > > It probably worked before 6064803313bad9ae4cae233a9d56678adb2b6e7c > ("perf tools: Use sscanf for parsing /proc/pid/maps"). > > Signed-off-by: Marcin Ślusarz > Cc: Namhyung Kim > Cc: Arnaldo Carvalho de Melo > --- > tools/perf/util/event.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c > index 8b10621..ff17fe6 100644 > --- a/tools/perf/util/event.c > +++ b/tools/perf/util/event.c > @@ -274,7 +274,7 @@ int perf_event__synthesize_mmap_events(struct perf_tool *tool, > strcpy(execname, ""); > > /* 00400000-0040c000 r-xp 00000000 fd:01 41038 /bin/cat */ > - n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %s\n", > + n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %[^\n]s\n", Is the last 's' necessary? Thanks, Namhyung > &event->mmap2.start, &event->mmap2.len, prot, > &event->mmap2.pgoff, &event->mmap2.maj, > &event->mmap2.min, > -- > 2.1.4 >