From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:41727 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751505AbcADJig (ORCPT ); Mon, 4 Jan 2016 04:38:36 -0500 Date: Mon, 4 Jan 2016 12:38:29 +0300 From: Dan Carpenter To: SF Markus Elfring Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Kalle Valo , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() Message-ID: <20160104093829.GE5284@mwanda> (sfid-20160104_103855_554320_4B218D89) References: <566ABCD9.1060404@users.sourceforge.net> <5687E169.4070704@users.sourceforge.net> <5687E203.1070404@users.sourceforge.net> <20160104092857.GD5284@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20160104092857.GD5284@mwanda> Sender: linux-wireless-owner@vger.kernel.org List-ID: Btw, GCC misses a lot of uninitialized variable bugs. I have a Smatch check which sometimes catches the bugs that GCC misses but you should not rely on the tools here. These patches need to be reviewed manually. And the "goto err" before the initialization makes everything more complicated (that's actually what caused the bug in this patch, in fact). regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Mon, 04 Jan 2016 09:38:29 +0000 Subject: Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() Message-Id: <20160104093829.GE5284@mwanda> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5687E169.4070704@users.sourceforge.net> <5687E203.1070404@users.sourceforge.net> <20160104092857.GD5284@mwanda> In-Reply-To: <20160104092857.GD5284@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Kalle Valo , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Btw, GCC misses a lot of uninitialized variable bugs. I have a Smatch check which sometimes catches the bugs that GCC misses but you should not rely on the tools here. These patches need to be reviewed manually. And the "goto err" before the initialization makes everything more complicated (that's actually what caused the bug in this patch, in fact). regards, dan carpenter