From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v3 1/6] xl: Return proper error codes for
 block-attach and block-detach
Date: Mon, 4 Jan 2016 14:30:37 +0000
Message-ID: <20160104143037.GB12639@citrix.com>
References: <1448970835-2706-1-git-send-email-george.dunlap@eu.citrix.com>
	<1449594928.16124.122.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1449594928.16124.122.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@citrix.com>, Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, Dec 08, 2015 at 05:15:28PM +0000, Ian Campbell wrote:
> On Tue, 2015-12-01 at 11:53 +0000, George Dunlap wrote:
> > Return proper error codes on failure so that scripts can tell whether
> > the command completed properly or not.
> > =

> > Also while we're at it, normalize init and dispose of
> > libxl_device_disk structures.=A0=A0This means calling init and dispose =
in
> > the actual functions where they are declared.
> > =

> > This in turn means changing parse_disk_config_multistring() to not
> > call libxl_device_disk_init.=A0=A0And that in turn means changes to
> > callers of parse_disk_config().
> > =

> > It also means removing libxl_device_disk_init() from
> > libxl.c:libxl_vdev_to_device_disk().=A0=A0This is only called from
> > xl_cmdimpl.c.
> =

> ... and the ocaml bindings.
> =

> I can't remember what we decided regarding libxl "getter" functions and
> initialisation of the data type (i.e. whose responsibility it is), but it
> seems that changing a given calls semantics is rather dangerous API-wise.
> =

> Wei, ISTR you stumbling over this once and the formulation of A Plan(tm),
> but I can't remember what it was, can you?
> =


I vaguely remember getting into something about libxl_device_disk_init
when I was discussing with with Jim regarding libvirt, but I can't
remember exactly what. It's probably a different issue.

Wei.