From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] common: cli: avoid memory leak
Date: Mon, 4 Jan 2016 14:59:54 -0500 [thread overview]
Message-ID: <20160104195954.GP4093@bill-the-cat> (raw)
In-Reply-To: <20151228051219.GA7046@linux-7smt.suse>
On Mon, Dec 28, 2015 at 01:12:21PM +0800, Peng Fan wrote:
> Hi Simon,
> On Sun, Dec 27, 2015 at 09:22:01PM -0700, Simon Glass wrote:
> >Hi Peng,
> >
> >On 22 December 2015 at 02:14, Peng Fan <van.freenix@gmail.com> wrote:
> >> From: Peng Fan <peng.fan@nxp.com>
> >>
> >> Whether CONFIG_SYS_HUSH_PARSER is defined or not, should always
> >> check to free 'buff' to avoid memory leak.
> >
> >Are you sure? I believe need_buff is only true if the simple parser is
> >being used.
>
> If CONFIG_SYS_HUSH_PARSER is defined and len is not -1, need_buff is 1, then
> will malloc buffer and assign return value to buff.
> But we only free buff, when CONFIG_SYS_HUSH_PARSER is not defined and need_buff is 1.
> So I think this may leaks memory.
Yes, this may happen. The code itself however should be rearranged (not
in this patch) to be clear on what we're doing here and if len will
really should ever be -1 (or always be -1?) or not.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160104/8797835d/attachment.sig>
next prev parent reply other threads:[~2016-01-04 19:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 9:14 [U-Boot] [PATCH 1/1] common: cli: avoid memory leak Peng Fan
2015-12-22 9:14 ` [U-Boot] [PATCH 1/1] common: env: initialize scalar variable Peng Fan
2015-12-22 9:29 ` Wolfgang Denk
2015-12-23 3:07 ` Peng Fan
2015-12-22 9:14 ` [U-Boot] [PATCH 1/1] common: nvedit: use snprintf instead of sprintf Peng Fan
2015-12-22 9:53 ` Fabio Estevam
2015-12-22 19:40 ` Tom Rini
2015-12-23 3:00 ` Peng Fan
2015-12-22 19:11 ` Joe Hershberger
2015-12-28 4:22 ` [U-Boot] [PATCH 1/1] common: cli: avoid memory leak Simon Glass
2015-12-28 5:12 ` Peng Fan
2016-01-04 19:59 ` Tom Rini [this message]
2016-01-04 22:23 ` [U-Boot] [U-Boot,1/1] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104195954.GP4093@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.