From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751739AbcAEOUL (ORCPT ); Tue, 5 Jan 2016 09:20:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53357 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751569AbcAEOUG (ORCPT ); Tue, 5 Jan 2016 09:20:06 -0500 Date: Tue, 5 Jan 2016 15:20:02 +0100 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Steven Rostedt , Frederic Weisbecker , Andi Kleen , Wang Nan Subject: Re: [PATCH v2 2/5] perf tools: Add all matching dynamic sort keys for field name Message-ID: <20160105142002.GB14602@krava.brq.redhat.com> References: <1451991518-25673-1-git-send-email-namhyung@kernel.org> <1451991518-25673-2-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451991518-25673-2-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 05, 2016 at 07:58:35PM +0900, Namhyung Kim wrote: > When a perf.data file has multiple events, it's likely to be similar > (tracepoint) events. In that case, they might have same field name so > add all of them to sort keys instead of bailing out. > > In addition, it contains a trivial whitespace fix at callsite of > add_all_dynamic_fields(). > > Signed-off-by: Namhyung Kim Acked-by: Jiri Olsa thanks, jirka