* [PATCH i-g-t] igt_core: Fix logging to display extended line
@ 2015-12-23 15:34 Derek Morton
2016-01-05 15:07 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Derek Morton @ 2015-12-23 15:34 UTC (permalink / raw)
To: intel-gfx; +Cc: thomas.wood
line[strlen(line)] will always evaluate to NULL so line_continuation
was always true. That prevented the program name, pid and log level
ever being printed.
Changed to [strlen(line) - 1] so the last character before the null
terminator is compared with '\n' to determine line_continuation.
Signed-off-by: Derek Morton <derek.j.morton@intel.com>
---
lib/igt_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_core.c b/lib/igt_core.c
index 84cf8d2..221ed7e 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -1748,7 +1748,7 @@ void igt_vlog(const char *domain, enum igt_log_level level, const char *format,
goto out;
}
- line_continuation = line[strlen(line)] != '\n';
+ line_continuation = line[strlen(line) - 1] != '\n';
/* append log buffer */
_igt_log_buffer_append(formatted_line);
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH i-g-t] igt_core: Fix logging to display extended line
2015-12-23 15:34 [PATCH i-g-t] igt_core: Fix logging to display extended line Derek Morton
@ 2016-01-05 15:07 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2016-01-05 15:07 UTC (permalink / raw)
To: Derek Morton; +Cc: intel-gfx, thomas.wood
On Wed, Dec 23, 2015 at 03:34:48PM +0000, Derek Morton wrote:
> line[strlen(line)] will always evaluate to NULL so line_continuation
> was always true. That prevented the program name, pid and log level
> ever being printed.
> Changed to [strlen(line) - 1] so the last character before the null
> terminator is compared with '\n' to determine line_continuation.
>
> Signed-off-by: Derek Morton <derek.j.morton@intel.com>
Ooops. Applied, thanks for the patch.
-Daniel
> ---
> lib/igt_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/igt_core.c b/lib/igt_core.c
> index 84cf8d2..221ed7e 100644
> --- a/lib/igt_core.c
> +++ b/lib/igt_core.c
> @@ -1748,7 +1748,7 @@ void igt_vlog(const char *domain, enum igt_log_level level, const char *format,
> goto out;
> }
>
> - line_continuation = line[strlen(line)] != '\n';
> + line_continuation = line[strlen(line) - 1] != '\n';
>
> /* append log buffer */
> _igt_log_buffer_append(formatted_line);
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-05 15:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-23 15:34 [PATCH i-g-t] igt_core: Fix logging to display extended line Derek Morton
2016-01-05 15:07 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.