From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 1/2] drm: Do not set outparam on error during GEM handle
 allocation
Date: Tue, 5 Jan 2016 16:14:32 +0100
Message-ID: <20160105151432.GC18886@ulmo.nvidia.com>
References: <1451986951-3703-1-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1509163380=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-pf0-f182.google.com (mail-pf0-f182.google.com
 [209.85.192.182])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 34D496E1DB
 for <dri-devel@lists.freedesktop.org>; Tue,  5 Jan 2016 07:14:36 -0800 (PST)
Received: by mail-pf0-f182.google.com with SMTP id 78so224274624pfw.2
 for <dri-devel@lists.freedesktop.org>; Tue, 05 Jan 2016 07:14:36 -0800 (PST)
In-Reply-To: <1451986951-3703-1-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org


--===============1509163380==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="DIOMP1UsTsWJauNi"
Content-Disposition: inline


--DIOMP1UsTsWJauNi
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 05, 2016 at 09:42:30AM +0000, Chris Wilson wrote:
> Good practice dictates that we do not leak stale information to our
> callers, and should avoid overwriting an outparam on an error path.
>=20
> Reported-by: Ville Syrj=C3=A4l=C3=A4 <ville.syrjala@linux.intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrj=C3=A4l=C3=A4 <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/drm_gem.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Thierry Reding <treding@nvidia.com>

--DIOMP1UsTsWJauNi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJWi93YAAoJEN0jrNd/PrOh0ccQAKx/u+BLrskAIkaj5rgL3hya
iSTdcMQSND2e00u1eBOz0CTh9eaoD1ecUG542ag6nsdDfNErLW7zJ9dA7Q1ICfxO
AL//ZxqtDihtoW9OPKtd461PJAb2fAEzoeMJHBc4wFdmKPsrCq0O8xMr/smIpI+2
bs59M+qhrO0YZlXNd6HZDAgOND3P+a6uBdUsEWlGQ0oSv++P5K9PSjZJH1SOinOX
ac42zRPS9xAi+UfY/MbqWJ0d8c3Dc/a+zkDhUWsc5GMbIMYHZfy25yULcZPOugP4
o2fnugMuBaMRMIvZpqNwSO4733/R3D/3hcKhyYrZKpI4JMIClImIIDi7InAu7Z2I
C2hAK6R3wJyXceQb2cWtMsJgVe2gWR8ZmHbKNYSfEEeHuEOv3kUtvafyaEERuRyt
4m5pdyOpDEq/F4r3EINM1upIqDkVTo2F1WO+5m2Cvc7Mh4A3PioQq1nPJ9dMEGjP
cmj4q3ZvhBOf0SuSG92htkTR7mLp9biu80cAXUkW1NDLVCkNnj5DH0wbRScgt2PL
vPTlfWgpMK8WF3M+jGX3SdgLJnynoo2f+3ywNbibFnEbSxB6nQMtv2M9V0/JOrvx
hJMxdvG9pQSE6NlHrZtk2TyHIDd3tMei1bhFuU/xXr+5QMbAyaYzOOoj3PfxodkW
ppieY1eVB8Z34icimli8
=eALS
-----END PGP SIGNATURE-----

--DIOMP1UsTsWJauNi--

--===============1509163380==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK

--===============1509163380==--