[Qemu-devel] [PATCH] linux-user: fix typo in trace formats

[Qemu-devel] [PATCH] linux-user: fix typo in trace formats

[Greg Kurz]

When building all targets, I get tons of warnings like below:

./trace/generated-tracers.h: In function ‘trace_user_s390x_restore_sigregs’:
./trace/generated-tracers.h:17551:25: warning: too many arguments for format
[-Wformat-extra-args]
                         , env, sc_psw_addr, env_psw_addr);

Fixes: c8ee0a445a6a85635e962c0346bc7b1259c1a3f5
Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
---
 trace-events |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/trace-events b/trace-events
index 6f036384a84f..ea5872dd72e2 100644
--- a/trace-events
+++ b/trace-events
@@ -1799,15 +1799,15 @@ qcrypto_tls_session_new(void *session, void *creds, const char *hostname, const
 vhost_user_event(const char *chr, int event) "chr: %s got event: %d"
 
 # linux-user/signal.c
-user_setup_frame(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64""
-user_setup_rt_frame(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64""
-user_do_rt_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64""
-user_do_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64""
+user_setup_frame(void *env, uint64_t frame_addr) "env=%p frame_addr=%"PRIx64""
+user_setup_rt_frame(void *env, uint64_t frame_addr) "env=%p frame_addr=%"PRIx64""
+user_do_rt_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr=%"PRIx64""
+user_do_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr=%"PRIx64""
 user_force_sig(void *env, int target_sig, int host_sig) "env=%p signal %d (host %d)"
 user_handle_signal(void *env, int target_sig) "env=%p signal %d"
 user_host_signal(void *env, int host_sig, int target_sig) "env=%p signal %d (target %d("
 user_queue_signal(void *env, int target_sig) "env=%p signal %d"
-user_s390x_restore_sigregs(void *env, uint64_t sc_psw_addr, uint64_t env_psw_addr) "env=%p frame psw.addr "PRIx64 " current psw.addr "PRIx64""
+user_s390x_restore_sigregs(void *env, uint64_t sc_psw_addr, uint64_t env_psw_addr) "env=%p frame psw.addr %"PRIx64 " current psw.addr %"PRIx64""
 
 # io/task.c
 qio_task_new(void *task, void *source, void *func, void *opaque) "Task new task=%p source=%p func=%p opaque=%p"

Re: [Qemu-devel] [PATCH] linux-user: fix typo in trace formats

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

On 01/05/2016 08:29 AM, Greg Kurz wrote:
> When building all targets, I get tons of warnings like below:
> 
> ./trace/generated-tracers.h: In function ‘trace_user_s390x_restore_sigregs’:
> ./trace/generated-tracers.h:17551:25: warning: too many arguments for format
> [-Wformat-extra-args]
>                          , env, sc_psw_addr, env_psw_addr);
> 
> Fixes: c8ee0a445a6a85635e962c0346bc7b1259c1a3f5
> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> ---
>  trace-events |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Duplicate of:
https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03667.html

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] [PATCH] linux-user: fix typo in trace formats

[Greg Kurz]

On Tue, 5 Jan 2016 08:52:39 -0700
Eric Blake <eblake@redhat.com> wrote:

> On 01/05/2016 08:29 AM, Greg Kurz wrote:
> > When building all targets, I get tons of warnings like below:
> > 
> > ./trace/generated-tracers.h: In function ‘trace_user_s390x_restore_sigregs’:
> > ./trace/generated-tracers.h:17551:25: warning: too many arguments for format
> > [-Wformat-extra-args]
> >                          , env, sc_psw_addr, env_psw_addr);
> > 
> > Fixes: c8ee0a445a6a85635e962c0346bc7b1259c1a3f5
> > Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> > ---
> >  trace-events |   10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> Duplicate of:
> https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03667.html
> 

Indeed I had missed that... I hope Stefan will send a pull request soon
because it is annoying when building all targets.

Thanks.

--
Greg