All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2 2/2] x11vnc: remove all references to moved package
Date: Tue, 5 Jan 2016 16:52:11 +0200	[thread overview]
Message-ID: <20160105165211.4a7efa0a@adi-pc-linux> (raw)
In-Reply-To: <CAJTo0LZE2vzpyaw4KLNRxPJjaVHYCTRtiA0qim25Y8zPAhQ45Q@mail.gmail.com>

On Tue, 5 Jan 2016 14:31:19 +0000
"Burton, Ross" <ross.burton@intel.com> wrote:

> On 5 January 2016 at 14:22, Ioan-Adrian Ratiu <adrian.ratiu@ni.com> wrote:
> 
> > Yes and also if there are no x11 dependencies in this packagegroup,
> > then it should be renamed to packagegroup-core-sato.
> >
> > I'll resubmit. Thank you.
> >
> 
> Don't - sato is explicitly X11 based.

I'm thinking that all recipes included in the sato image define
REQUIRED_DISTRO_FEATURES = "x11" themselves, like matchbox-desktop does,
so there's no need to define it again in the packagegroup recipe, since no
package actually requires it there.

I thought the same rationale also applies to the packagegroup names. However
now I understand the need to propagate the indirect x11 dependency in the names.

So I'll just remove the features check as per Martin's suggestion and leave the name as it is.

> 
> Ross



  reply	other threads:[~2016-01-05 14:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05 12:24 [PATCH v2 1/2] x11vnc: move recipe to meta-oe Ioan-Adrian Ratiu
2016-01-05 12:24 ` [PATCH v2 2/2] x11vnc: remove all references to moved package Ioan-Adrian Ratiu
2016-01-05 13:41   ` Martin Jansa
2016-01-05 14:22     ` Ioan-Adrian Ratiu
2016-01-05 14:31       ` Burton, Ross
2016-01-05 14:52         ` Ioan-Adrian Ratiu [this message]
2016-01-05 15:25         ` Ioan-Adrian Ratiu
2016-01-05 15:32           ` Burton, Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160105165211.4a7efa0a@adi-pc-linux \
    --to=adrian.ratiu@ni.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.