From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 4FCD97F3F for ; Tue, 5 Jan 2016 23:31:30 -0600 (CST) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id 40F20304053 for ; Tue, 5 Jan 2016 21:31:27 -0800 (PST) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id U11VTN7hUI7JTFSi (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Tue, 05 Jan 2016 21:31:24 -0800 (PST) Date: Tue, 5 Jan 2016 21:31:23 -0800 From: Christoph Hellwig Subject: Re: [PATCH V4] xfs: eliminate committed arg from xfs_bmap_finish Message-ID: <20160106053123.GA19935@infradead.org> References: <56441B8E.6070603@redhat.com> <5644BEF8.6070201@sandeen.net> <568C131C.9080907@sandeen.net> <568C917C.9050509@sandeen.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <568C917C.9050509@sandeen.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: xfs@oss.sgi.com Looks great! Reviewed-by: Christoph Hellwig Note that the "if (*tpp != tp)" trick also works in xfs_bmap_finish, which will allows us to fold __xfs_trans_roll into xfs_trans_roll in a follow on patch. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs