From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752305AbcAFOZ2 (ORCPT ); Wed, 6 Jan 2016 09:25:28 -0500 Received: from mail.kernel.org ([198.145.29.136]:43800 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751865AbcAFOZ0 (ORCPT ); Wed, 6 Jan 2016 09:25:26 -0500 Date: Wed, 6 Jan 2016 08:25:21 -0600 From: Rob Herring To: Mark Brown Cc: Laxman Dewangan , pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] regulator: max8973: add support for junction thermal warning Message-ID: <20160106142521.GA11188@rob-hp-laptop> References: <1452060922-24426-1-git-send-email-ldewangan@nvidia.com> <20160106121857.GW6588@sirena.org.uk> <568D064A.8080609@nvidia.com> <20160106123735.GX6588@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160106123735.GX6588@sirena.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 06, 2016 at 12:37:35PM +0000, Mark Brown wrote: > On Wed, Jan 06, 2016 at 05:49:22PM +0530, Laxman Dewangan wrote: > > On Wednesday 06 January 2016 05:48 PM, Mark Brown wrote: > > >* PGP Signed by an unknown key > > > >On Wed, Jan 06, 2016 at 11:45:22AM +0530, Laxman Dewangan wrote: > > > >> Enhanced transient response (ETR) will affect the configuration of CKADV. > > >>+-maxim,junction-temp-warning: Junction temp warning on which device generates > > >>+ warning interrupts. > > >This needs to specify what the values are - it looks like it's raw > > >register values but I'd have expected from this that it'd be an actual > > >temperature. > > > I tried to roundoff to the next higher threshold when supported value (120 > > or 140 degC) is not provided in driver. But it is fine to me to specify the > > possible value setting here and DT binding doc. Will do on next patch. > > I don't really mind which you use so long as the documentation is clear. I prefer that degrees are used rather than register values. Rob