From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752218AbcAFO2f (ORCPT ); Wed, 6 Jan 2016 09:28:35 -0500 Received: from mail1.windriver.com ([147.11.146.13]:49009 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751870AbcAFO2d (ORCPT ); Wed, 6 Jan 2016 09:28:33 -0500 Date: Wed, 6 Jan 2016 09:26:12 -0500 From: Paul Gortmaker To: Michal Hocko CC: Andrew Morton , Mel Gorman , Tetsuo Handa , David Rientjes , Linus Torvalds , Oleg Nesterov , Hugh Dickins , Andrea Argangeli , Rik van Riel , , LKML Subject: Re: [PATCH 1/2] mm, oom: introduce oom reaper Message-ID: <20160106142611.GD2957@windriver.com> References: <1450204575-13052-1-git-send-email-mhocko@kernel.org> <20160106091027.GA13900@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160106091027.GA13900@dhcp22.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Re: [PATCH 1/2] mm, oom: introduce oom reaper] On 06/01/2016 (Wed 10:10) Michal Hocko wrote: > On Mon 21-12-15 15:38:21, Paul Gortmaker wrote: > [...] > > ...use one of the non-modular initcalls here? I'm trying to clean up most of > > the non-modular uses of modular macros etc. since: > > > > (1) it is easy to accidentally code up an unused module_exit function > > (2) it can be misleading when reading the source, thinking it can be > > modular when the Makefile and/or Kconfig prohibit it > > (3) it requires the include of the module.h header file which in turn > > includes nearly everything else, thus increasing CPP overhead. > > > > I figured no point in sending a follow on patch since this came in via > > the akpm tree into next and that gets rebased/updated regularly. > > Sorry for the late reply. I was mostly offline throughout the last 2 > weeks last year. Is the following what you would like to see? If yes I > will fold it into the original patch. Yes, that looks fine. Do note that susbsys_initcall is earlier than the module_init that you were using previously though. Thanks, Paul. -- > > Thanks! > --- > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 7a9678c50edd..1ece40b94725 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -36,7 +36,7 @@ > #include > #include > #include > -#include > +#include > > #include > #include "internal.h" > @@ -541,7 +541,7 @@ static int __init oom_init(void) > } > return 0; > } > -module_init(oom_init) > +subsys_initcall(oom_init) > #else > static void wake_oom_reaper(struct mm_struct *mm) > { > -- > Michal Hocko > SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yk0-f180.google.com (mail-yk0-f180.google.com [209.85.160.180]) by kanga.kvack.org (Postfix) with ESMTP id D87766B0003 for ; Wed, 6 Jan 2016 09:26:22 -0500 (EST) Received: by mail-yk0-f180.google.com with SMTP id a85so239262743ykb.1 for ; Wed, 06 Jan 2016 06:26:22 -0800 (PST) Received: from mail1.windriver.com (mail1.windriver.com. [147.11.146.13]) by mx.google.com with ESMTPS id q5si59810412ywb.370.2016.01.06.06.26.21 for (version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 Jan 2016 06:26:21 -0800 (PST) Date: Wed, 6 Jan 2016 09:26:12 -0500 From: Paul Gortmaker Subject: Re: [PATCH 1/2] mm, oom: introduce oom reaper Message-ID: <20160106142611.GD2957@windriver.com> References: <1450204575-13052-1-git-send-email-mhocko@kernel.org> <20160106091027.GA13900@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160106091027.GA13900@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Andrew Morton , Mel Gorman , Tetsuo Handa , David Rientjes , Linus Torvalds , Oleg Nesterov , Hugh Dickins , Andrea Argangeli , Rik van Riel , linux-mm@kvack.org, LKML [Re: [PATCH 1/2] mm, oom: introduce oom reaper] On 06/01/2016 (Wed 10:10) Michal Hocko wrote: > On Mon 21-12-15 15:38:21, Paul Gortmaker wrote: > [...] > > ...use one of the non-modular initcalls here? I'm trying to clean up most of > > the non-modular uses of modular macros etc. since: > > > > (1) it is easy to accidentally code up an unused module_exit function > > (2) it can be misleading when reading the source, thinking it can be > > modular when the Makefile and/or Kconfig prohibit it > > (3) it requires the include of the module.h header file which in turn > > includes nearly everything else, thus increasing CPP overhead. > > > > I figured no point in sending a follow on patch since this came in via > > the akpm tree into next and that gets rebased/updated regularly. > > Sorry for the late reply. I was mostly offline throughout the last 2 > weeks last year. Is the following what you would like to see? If yes I > will fold it into the original patch. Yes, that looks fine. Do note that susbsys_initcall is earlier than the module_init that you were using previously though. Thanks, Paul. -- > > Thanks! > --- > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 7a9678c50edd..1ece40b94725 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -36,7 +36,7 @@ > #include > #include > #include > -#include > +#include > > #include > #include "internal.h" > @@ -541,7 +541,7 @@ static int __init oom_init(void) > } > return 0; > } > -module_init(oom_init) > +subsys_initcall(oom_init) > #else > static void wake_oom_reaper(struct mm_struct *mm) > { > -- > Michal Hocko > SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org