From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH v2 11/13] tools: split up xen-init-dom0.c Date: Wed, 6 Jan 2016 16:33:12 +0000 Message-ID: <20160106163312.GN27789@citrix.com> References: <1450444471-6454-1-git-send-email-jgross@suse.com> <1450444471-6454-12-git-send-email-jgross@suse.com> <1452097570.21055.109.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1452097570.21055.109.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Juergen Gross , wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org On Wed, Jan 06, 2016 at 04:26:10PM +0000, Ian Campbell wrote: > On Fri, 2015-12-18 at 14:14 +0100, Juergen Gross wrote: > > Split up tools/helpers/xen-init-dom0.c in order to prepare reusing > > generation of the json configuration by init-xenstore-domain.c. > > > > Signed-off-by: Juergen Gross > > Wei, was there a reason for using atexit() to free the handles which I'm > not seeing? IOW I think there is a single exit path which could have done > all that today, so Juergen is OK to change it in this way. > No, there isn't particular reason to use atexit. I copied it from xl. It's OK for Juergen to change it. Wei.