From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 6 Jan 2016 21:58:36 +0100 Subject: [U-Boot] [PATCH 3/3] pcie_layerscape: Adjust the return value when ls_pcie_addr_valid() fails In-Reply-To: <1452113598-32409-3-git-send-email-festevam@gmail.com> References: <1452113598-32409-1-git-send-email-festevam@gmail.com> <1452113598-32409-3-git-send-email-festevam@gmail.com> Message-ID: <201601062158.37058.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday, January 06, 2016 at 09:53:18 PM, Fabio Estevam wrote: > From: Fabio Estevam > > Since commit ff3e077bd2 ("dm: pci: Add a uclass for PCI") the following > error message is seen: > > => pci 0 > Scanning PCI devices on bus 0 > BusDevFun VendorId DeviceId Device Class Sub-Class > _____________________________________________________________ > 00.01.00 0x16c3 0xabcd Bridge device 0x04 > Cannot read bus configuration: -1 > > We can avoid this error by using the same approach as done in the > linux kernel PCI designware driver: (drivers/pci/host/pcie-designware.c) > > static int dw_pcie_rd_conf(struct pci_bus *bus, u32 devfn, int where, > int size, u32 *val) > { > struct pcie_port *pp = bus->sysdata; > int ret; > > if (dw_pcie_valid_config(pp, bus, PCI_SLOT(devfn)) == 0) { > *val = 0xffffffff; > return PCIBIOS_DEVICE_NOT_FOUND; > } > > ,where PCIBIOS_DEVICE_NOT_FOUND is returned when an invalid address > is given. > > Reported-by: Bin Meng > Signed-off-by: Fabio Estevam Good stuff, thanks! Acked-by: Marek Vasut I added Stefano on CC, so I added him. I'd like to see all three in mainline for this MW. Best regards, Marek Vasut