From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: socfpga: set the fpga global bit to disable HPS to FPGA signals
Date: Thu, 7 Jan 2016 04:20:23 +0100 [thread overview]
Message-ID: <201601070420.23773.marex@denx.de> (raw)
In-Reply-To: <568DD258.9060401@kernel.org>
On Thursday, January 07, 2016 at 03:50:00 AM, Dinh Nguyen wrote:
> On 01/06/2016 08:21 PM, Marek Vasut wrote:
> > On Wednesday, January 06, 2016 at 08:48:43 PM,
> > dinguyen at opensource.altera.com
> >
> > wrote:
> >> From: Dinh Nguyen <dinh.linux@gmail.com>
> >>
> >> We should be setting the FPGA Interface Group global bit that will
> >> correctly disable all interfaces between the FPGA and HPS.
> >>
> >> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> >> ---
> >>
> >> drivers/fpga/socfpga.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c
> >> index 4448250..431e159 100644
> >> --- a/drivers/fpga/socfpga.c
> >> +++ b/drivers/fpga/socfpga.c
> >> @@ -269,7 +269,7 @@ int socfpga_load(Altera_desc *desc, const void
> >> *rbf_data, size_t rbf_size) /* Prior programming the FPGA, all bridges
> >> need to be shut off */
> >>
> >> /* Disable all signals from hps peripheral controller to fpga */
> >>
> >> - writel(0, &sysmgr_regs->fpgaintfgrp_module);
> >> + writel(0, &sysmgr_regs->fpgaintfgrp_gbl);
> >>
> >> /* Disable all signals from FPGA to HPS SDRAM */
> >>
> >> #define SDR_CTRLGRP_FPGAPORTRST_ADDRESS 0x5080
> >
> > Looks fine,
> >
> > Acked-by: Marek Vasut <marex@denx.de>
> >
> > btw Shouldn't you also fix the same thing in drivers/fpga/socfpga.c ?
> > Even
>
> I'm confused by what you mean here. The patch is for
> drivers/fpga/socfpga.c.
Oops, sorry, there is another one in arch/arm/mach-socfpga/misc.c . I mispasted
the wrong filename.
> > better, can't we have a single function to enable/disable the interfaces?
>
> We probably could, but I don't see a need for other functions to
> enable/disable the interfaces.
>
> Dinh
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-01-07 3:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 19:48 [U-Boot] [PATCH] arm: socfpga: set the fpga global bit to disable HPS to FPGA signals dinguyen at opensource.altera.com
2016-01-07 2:21 ` Marek Vasut
2016-01-07 2:50 ` Dinh Nguyen
2016-01-07 3:20 ` Marek Vasut [this message]
2016-01-07 15:03 ` Dinh Nguyen
2016-01-07 15:07 ` Marek Vasut
2016-01-07 15:23 ` Dinh Nguyen
2016-01-07 15:33 ` Marek Vasut
2016-01-08 10:15 ` Chin Liang See
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201601070420.23773.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.