From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aH7LW-0002r8-Vb for qemu-devel@nongnu.org; Thu, 07 Jan 2016 04:59:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aH7LS-0006PB-Je for qemu-devel@nongnu.org; Thu, 07 Jan 2016 04:59:06 -0500 Received: from mail-pa0-x22b.google.com ([2607:f8b0:400e:c03::22b]:33118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aH7LS-0006P7-BM for qemu-devel@nongnu.org; Thu, 07 Jan 2016 04:59:02 -0500 Received: by mail-pa0-x22b.google.com with SMTP id cy9so255039819pac.0 for ; Thu, 07 Jan 2016 01:59:02 -0800 (PST) Date: Thu, 7 Jan 2016 17:58:56 +0800 From: Stefan Hajnoczi Message-ID: <20160107095856.GA17701@stefanha-x1.localdomain> References: <1446151457-21157-1-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ReaqsoxgOBHFXBhH" Content-Disposition: inline In-Reply-To: <1446151457-21157-1-git-send-email-den@openvz.org> Subject: Re: [Qemu-devel] [PATCH v3 00/11] simplify usage of tracepoints, and connect them to logging List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Paolo Bonzini , qemu-devel@nongnu.org --ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 29, 2015 at 11:44:06PM +0300, Denis V. Lunev wrote: > This series does three things: >=20 > 1) add a "-trace [enable=3D]foo" option to enable one or more trace > events, and a "-trace help" option to show the list of tracepoints > (patches 4-5) >=20 > 2) change the stderr tracing backend so that it prints to the > -D log file, and enable it by default. "-trace file=3D..." is > now a synonym of -D if the log backend is enabled (patches 7-8) >=20 > 3) add a "-d trace:foo" option that is a synonym for "-trace foo"; > this makes the new functionality more discoverable to people used > to "-d", makes it available for user-mode emulation (which does > not have -trace), and is somewhat nice if you want to enable both > tracepoints and some other "-d" flag (patch 9). When globbing > it is also less susceptible to unwanted shell expansion. >=20 > For example, you can trace block device I/O and save the result > to a file just by adding "-trace bdrv_aio_*,file=3Dtrace.txt", or > correlate it to guest PCs with "-d exec,nochain,trace:bdrv_aio_*". >=20 > Opinions? I would like to have this in 2.5 if there is agreement. >=20 > Signed-off-by: Paolo Bonzini > Signed-off-by: Denis V. Lunev >=20 > Changes from v2: > - compilation fix was extended to patch 2 and 3 > - replaced Reviewed-by with Acked-by by request from Christian >=20 > Changes from v1: > - small cleanup to vl.c is added as patch (4) > - compilation is fixed in patch (2) > - moved qemu-log.c to util/log.c to fix linking of qemu-io/qemu-nbd >=20 > Denis V. Lunev (2): > trace: no need to call trace_backend_init in different branches now > log: move qemu-log.c into util/ directory >=20 > Paolo Bonzini (9): > trace: fix documentation > trace: split trace_init_events out of trace_init_backends > trace: split trace_init_file out of trace_init_backends > trace: add "-trace enable=3D..." > trace: add "-trace help" > log: do not unnecessarily include qom/cpu.h > trace: convert stderr backend to log > trace: switch default backend to "log" > log: add "-d trace:PATTERN" >=20 > Makefile.objs | 1 - > bsd-user/main.c | 1 + > configure | 6 +- > cpu-exec.c | 1 + > exec.c | 1 + > hw/acpi/cpu_hotplug.c | 1 + > hw/timer/a9gtimer.c | 1 + > include/exec/log.h | 60 ++++++++++++++++ > include/qemu/log.h | 60 +--------------- > linux-user/main.c | 1 + > qemu-io.c | 2 +- > qemu-options.hx | 22 ++++-- > qom/cpu.c | 1 + > scripts/tracetool/backend/{stderr.py =3D> log.py} | 9 +-- > target-alpha/translate.c | 1 + > target-arm/translate.c | 1 + > target-cris/translate.c | 1 + > target-i386/seg_helper.c | 1 + > target-i386/smm_helper.c | 1 + > target-i386/translate.c | 1 + > target-lm32/helper.c | 1 + > target-lm32/translate.c | 1 + > target-m68k/translate.c | 1 + > target-microblaze/helper.c | 1 + > target-microblaze/translate.c | 1 + > target-mips/helper.c | 1 + > target-mips/translate.c | 1 + > target-moxie/translate.c | 1 + > target-openrisc/translate.c | 1 + > target-ppc/mmu-hash32.c | 1 + > target-ppc/mmu-hash64.c | 1 + > target-ppc/mmu_helper.c | 1 + > target-ppc/translate.c | 1 + > target-s390x/translate.c | 1 + > target-sh4/helper.c | 1 + > target-sh4/translate.c | 1 + > target-sparc/int32_helper.c | 1 + > target-sparc/int64_helper.c | 1 + > target-sparc/translate.c | 1 + > target-tilegx/translate.c | 1 + > target-tricore/translate.c | 1 + > target-unicore32/translate.c | 1 + > target-xtensa/translate.c | 1 + > tcg/tcg.c | 1 + > trace/control.c | 95 ++++++++++++++++++-= ------ > trace/control.h | 42 ++++++++++- > trace/simple.c | 6 +- > trace/simple.h | 4 +- > translate-all.c | 1 + > util/Makefile.objs | 1 + > qemu-log.c =3D> util/log.c | 19 ++++- > vl.c | 38 +++++----- > 52 files changed, 274 insertions(+), 129 deletions(-) > create mode 100644 include/exec/log.h > rename scripts/tracetool/backend/{stderr.py =3D> log.py} (78%) > rename qemu-log.c =3D> util/log.c (90%) Hi Denis, I have pasted the issues that Peter Maydell hit during QEMU 2.5 below. Please rebase this series onto https://github.com/stefanha/qemu/commits/tracing-pull-request (cef517ca4bf890ef5405aac1b95f75dcda043d6a) I'll rerun the Windows build on the next revision to make sure the warnings have been fixed. Thanks, Stefan --- 1. Fails to build on all platforms :-( /home/petmay01/linaro/qemu-for-merges/target-arm/translate-a64.c: In function =E2=80=98gen_intermediate_code_a64=E2=80=99: /home/petmay01/linaro/qemu-for-merges/target-arm/translate-a64.c:11229:9: error: implicit declaration of function =E2=80=98lookup_symbol=E2=80=99 [-Werror=3Dimplicit-function-declaration] qemu_log("IN: %s\n", lookup_symbol(pc_start)); ^ /home/petmay01/linaro/qemu-for-merges/target-arm/translate-a64.c:11229:9: error: nested extern declaration of =E2=80=98lookup_symbol=E2=80=99 [-Werror=3Dnested-externs] /home/petmay01/linaro/qemu-for-merges/target-arm/translate-a64.c:11229:9: error: format =E2=80=98%s=E2=80=99 expects argument of type =E2=80=98char *= =E2=80=99, but argument 2 has type =E2=80=98int=E2=80=99 [-Werror=3Dformat=3D] /home/petmay01/linaro/qemu-for-merges/target-arm/translate-a64.c:11230:9: error: implicit declaration of function =E2=80=98log_target_disas=E2=80=99 [-Werror=3Dimplicit-function-declaration] log_target_disas(cs, pc_start, dc->pc - pc_start, ^ /home/petmay01/linaro/qemu-for-merges/target-arm/translate-a64.c:11230:9: error: nested extern declaration of =E2=80=98log_target_disas=E2=80=99 [-Werror=3Dnested-externs] cc1: all warnings being treated as errors 2. w32 fails to build with the same 'ssize_t vs signed size_t for %zd' thing that hit somebody else's changes earlier this week: In file included from /home/petmay01/linaro/qemu-for-merges/include/trace.h= :4, from /home/petmay01/linaro/qemu-for-merges/util/oslib-win32.c:38: =2E/trace/generated-tracers.h: In function =E2=80=98trace_virtio_console_fl= ush_buf=E2=80=99: =2E/trace/generated-tracers.h:240: warning: format =E2=80=98%zd=E2=80=99 ex= pects type =E2=80=98signed size_t=E2=80=99, but argument 8 has type =E2=80=98ssize_t= =E2=80=99 CC util/bitops.o =2E/trace/generated-tracers.h: In function =E2=80=98trace_usb_ohci_iso_td_s= o=E2=80=99: =2E/trace/generated-tracers.h:2784: warning: format =E2=80=98%zu=E2=80=99 e= xpects type =E2=80=98size_t=E2=80=99, but argument 11 has type =E2=80=98ssize_t=E2=80=99 =2E/trace/generated-tracers.h: In function =E2=80=98trace_usb_ohci_iso_td_d= ata_overrun=E2=80=99: =2E/trace/generated-tracers.h:2796: warning: format =E2=80=98%zu=E2=80=99 e= xpects type =E2=80=98size_t=E2=80=99, but argument 7 has type =E2=80=98ssize_t=E2=80=99 CC util/hbitmap.o CC util/fifo8.o =2E/trace/generated-tracers.h: In function =E2=80=98trace_spice_vmc_write= =E2=80=99: =2E/trace/generated-tracers.h:6492: warning: format =E2=80=98%zd=E2=80=99 e= xpects type =E2=80=98signed size_t=E2=80=99, but argument 6 has type =E2=80=98ssize_t= =E2=80=99 CC util/acl.o CC util/error.o =2E/trace/generated-tracers.h: In function =E2=80=98trace_v9fs_read_return= =E2=80=99: =2E/trace/generated-tracers.h:10344: warning: format =E2=80=98%zd=E2=80=99 = expects type =E2=80=98signed size_t=E2=80=99, but argument 9 has type =E2=80=98ssize_t= =E2=80=99 =2E/trace/generated-tracers.h: In function =E2=80=98trace_v9fs_readdir_retu= rn=E2=80=99: =2E/trace/generated-tracers.h:10368: warning: format =E2=80=98%zd=E2=80=99 = expects type =E2=80=98signed size_t=E2=80=99, but argument 9 has type =E2=80=98ssize_t= =E2=80=99 =2E/trace/generated-tracers.h: In function =E2=80=98trace_v9fs_write_return= =E2=80=99: =2E/trace/generated-tracers.h:10392: warning: format =E2=80=98%zd=E2=80=99 = expects type =E2=80=98signed size_t=E2=80=99, but argument 9 has type =E2=80=98ssize_t= =E2=80=99 CC util/qemu-error.o CC util/id.o CC util/iov.o cc1: warnings being treated as errors In file included from /home/petmay01/linaro/qemu-for-merges/include/trace.h= :4, from /home/petmay01/linaro/qemu-for-merges/util/hbitmap.c:= 18: =2E/trace/generated-tracers.h: In function =E2=80=98trace_virtio_console_fl= ush_buf=E2=80=99: =2E/trace/generated-tracers.h:240: warning: format =E2=80=98%zd=E2=80=99 ex= pects type =E2=80=98signed size_t=E2=80=99, but argument 8 has type =E2=80=98ssize_t= =E2=80=99 CC util/qemu-config.o =2E/trace/generated-tracers.h: In function =E2=80=98trace_usb_ohci_iso_td_s= o=E2=80=99: =2E/trace/generated-tracers.h:2784: warning: format =E2=80=98%zu=E2=80=99 e= xpects type =E2=80=98size_t=E2=80=99, but argument 11 has type =E2=80=98ssize_t=E2=80=99 =2E/trace/generated-tracers.h: In function =E2=80=98trace_usb_ohci_iso_td_d= ata_overrun=E2=80=99: =2E/trace/generated-tracers.h:2796: warning: format =E2=80=98%zu=E2=80=99 e= xpects type =E2=80=98size_t=E2=80=99, but argument 7 has type =E2=80=98ssize_t=E2=80=99 make: *** [util/oslib-win32.o] Error 1 make: *** Waiting for unfinished jobs.... =2E/trace/generated-tracers.h: In function =E2=80=98trace_spice_vmc_write= =E2=80=99: =2E/trace/generated-tracers.h:6492: warning: format =E2=80=98%zd=E2=80=99 e= xpects type =E2=80=98signed size_t=E2=80=99, but argument 6 has type =E2=80=98ssize_t= =E2=80=99 =2E/trace/generated-tracers.h: In function =E2=80=98trace_v9fs_read_return= =E2=80=99: =2E/trace/generated-tracers.h:10344: warning: format =E2=80=98%zd=E2=80=99 = expects type =E2=80=98signed size_t=E2=80=99, but argument 9 has type =E2=80=98ssize_t= =E2=80=99 =2E/trace/generated-tracers.h: In function =E2=80=98trace_v9fs_readdir_retu= rn=E2=80=99: =2E/trace/generated-tracers.h:10368: warning: format =E2=80=98%zd=E2=80=99 = expects type =E2=80=98signed size_t=E2=80=99, but argument 9 has type =E2=80=98ssize_t= =E2=80=99 =2E/trace/generated-tracers.h: In function =E2=80=98trace_v9fs_write_return= =E2=80=99: =2E/trace/generated-tracers.h:10392: warning: format =E2=80=98%zd=E2=80=99 = expects type =E2=80=98signed size_t=E2=80=99, but argument 9 has type =E2=80=98ssize_t= =E2=80=99 make: *** [util/hbitmap.o] Error 1 make: Leaving directory `/home/petmay01/linaro/qemu-for-merges/build/w32' 3. I also now get a handful of extra warnings in the 'make check' output: /aarch64/qom/xilinx-zynq-a9: OK /aarch64/qom/xlnx-ep108: WARNING: RAM size 8000000 is small for EP108OK /aarch64/qom/vexpress-a9: OK (note the missing newline...) TEST: tests/qom-test... (pid=3D19738) /microblaze/qom/none: OK /microblaze/qom/petalogix-s3adsp1800: Invalid MicroBlaze version number: (null) OK /microblaze/qom/petalogix-ml605: Invalid MicroBlaze version number: (null) OK --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWjja+AAoJEJykq7OBq3PIN6QH/1gyNPVQhzFyD2asiuEZh5qZ 7q6/9HSVvErsTSKWY8HqMtAFFrahI69Q0DZXRwAfjA6lhY7pn6bKIr8xWXn7XvAn wOs6MGGVBvTs6BFdDVGGIOEdZjDiBam5U6qYDd2t5zPBaUiTlzcT7iPpgV3OQxNb 5vCrIrYxhK5NPuY0Fa+LjLmJDpOoB1SPCGsVcs23ysjNrdYUnaWa5FSZz8vVLMHE fas7Ys7ffO65UslU9Qn5wwk34TRsdF5dE1w0K7uKqsYBjkrQAC/M+GhbnYc4IVCM 52ZRYjq1yRX/afrCp9hVvO5XgJ1ghecPfBQNCbTgwk46txkkXCoXDcb8wZQ6mfc= =1Wm5 -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH--