From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752830AbcAGLSh (ORCPT ); Thu, 7 Jan 2016 06:18:37 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:35871 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752745AbcAGLSe (ORCPT ); Thu, 7 Jan 2016 06:18:34 -0500 Date: Thu, 7 Jan 2016 20:17:40 +0900 From: Namhyung Kim To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , lkml , David Ahern , Ingo Molnar , Peter Zijlstra , Noel Grandin , Adrian Hunter Subject: Re: [PATCH 12/13] perf diff: Use perf_hpp__register_sort_field interface Message-ID: <20160107111740.GH5499@danjae.kornet> References: <1452158050-28061-1-git-send-email-jolsa@kernel.org> <1452158050-28061-13-git-send-email-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1452158050-28061-13-git-send-email-jolsa@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 07, 2016 at 10:14:09AM +0100, Jiri Olsa wrote: > Using perf_hpp__register_sort_field interface > instead of directly adding the entry. > > Link: http://lkml.kernel.org/n/tip-m1vdmvod7vcbdit0ix7bjp7z@git.kernel.org > Signed-off-by: Jiri Olsa Acked-by: Namhyung Kim Thanks, Namhyung > --- > tools/perf/builtin-diff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c > index 87063835d741..36ccc2b8827f 100644 > --- a/tools/perf/builtin-diff.c > +++ b/tools/perf/builtin-diff.c > @@ -1207,7 +1207,7 @@ static int ui_init(void) > BUG_ON(1); > } > > - list_add(&fmt->sort_list, &perf_hpp__sort_list); > + perf_hpp__register_sort_field(fmt); > return 0; > } > > -- > 2.4.3 >