From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752807AbcAGPsx (ORCPT ); Thu, 7 Jan 2016 10:48:53 -0500 Received: from mail-qk0-f182.google.com ([209.85.220.182]:34277 "EHLO mail-qk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbcAGPsw (ORCPT ); Thu, 7 Jan 2016 10:48:52 -0500 Date: Thu, 7 Jan 2016 10:48:50 -0500 From: Tejun Heo To: wanghaibin Cc: linux-kernel@vger.kernel.org, jiangshanlai@gmail.com, peter.huangpeng@huawei.com Subject: Re: [RFC PATCH 1/4] workqueue: move the wq_update_unbound_numa_attrs_buf allocation location. Message-ID: <20160107154850.GA1898@mtj.duckdns.org> References: <1452170339-26748-1-git-send-email-wanghaibin.wang@huawei.com> <1452170339-26748-2-git-send-email-wanghaibin.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452170339-26748-2-git-send-email-wanghaibin.wang@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 07, 2016 at 08:38:56PM +0800, wanghaibin wrote: > the wq_update_unbound_numa_attrs_buf will be useful, only when the > wq_numa_enabled is true. > if there is something wrong to cause the wq_numa_enable false, it > can just return without the wq_update_unbound_numa_attrs_buf > allocation. > > This doesn't introduce any functional changes. I don't see what the point is with this change. Thanks. -- tejun