From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753829AbcAGQAJ (ORCPT ); Thu, 7 Jan 2016 11:00:09 -0500 Received: from mail-qk0-f170.google.com ([209.85.220.170]:32847 "EHLO mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752283AbcAGQAH (ORCPT ); Thu, 7 Jan 2016 11:00:07 -0500 Date: Thu, 7 Jan 2016 11:00:05 -0500 From: Tejun Heo To: wanghaibin Cc: linux-kernel@vger.kernel.org, jiangshanlai@gmail.com, peter.huangpeng@huawei.com Subject: Re: [RFC PATCH 3/4] workqueue: remove the unbind workqueue attr sys_file before unregister the workqueue device Message-ID: <20160107160005.GC1898@mtj.duckdns.org> References: <1452170339-26748-1-git-send-email-wanghaibin.wang@huawei.com> <1452170339-26748-4-git-send-email-wanghaibin.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452170339-26748-4-git-send-email-wanghaibin.wang@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 07, 2016 at 08:38:58PM +0800, wanghaibin wrote: > for workqueue's flag with the WQ_SYSFS | WQ_UNBOUND, the wq_dev will create some sys_files for > unbound attrs, so, remove the unbind workqueue attrs sys_files before unregister the > workqueue device. File removal on sysfs is recursive, right? Does explicitly removing file make any difference? -- tejun