From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHDvx-0007op-Qj for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:01:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHDvv-00040C-3A for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:01:09 -0500 Received: from e06smtp07.uk.ibm.com ([195.75.94.103]:44237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHDvu-0003zu-Iq for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:01:06 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 Jan 2016 17:01:04 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 9AA2E2190046 for ; Thu, 7 Jan 2016 17:00:52 +0000 (GMT) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u07H13hb8585706 for ; Thu, 7 Jan 2016 17:01:03 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u07H12no017385 for ; Thu, 7 Jan 2016 10:01:03 -0700 Date: Thu, 7 Jan 2016 18:00:59 +0100 From: Greg Kurz Message-ID: <20160107180059.73f95d57@bahia.local> In-Reply-To: <87mvshqr4o.fsf@linux.vnet.ibm.com> References: <1452020761-24457-1-git-send-email-wei.liu2@citrix.com> <1452020761-24457-10-git-send-email-wei.liu2@citrix.com> <87mvshqr4o.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/22] 9pfs: remove dead code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" Cc: Wei Liu , qemu-devel@nongnu.org, "Michael S. Tsirkin" On Thu, 07 Jan 2016 22:11:11 +0530 "Aneesh Kumar K.V" wrote: > Wei Liu writes: > > > Some structures virtio-9p.h have been unused since 2011 when relevant > > functions switched to use coroutines. > > > > The declaration of pdu_packunpack and function do_pdu_unpack are > > useless. > > > > The function virtio_9p_set_fd_limit is unused. > > > > Signed-off-by: Wei Liu > > --- > > hw/9pfs/virtio-9p.c | 11 --------- > > hw/9pfs/virtio-9p.h | 68 ----------------------------------------------------- > > 2 files changed, 79 deletions(-) > > > > diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c > > index 30ff828..084fa6a 100644 > > --- a/hw/9pfs/virtio-9p.c > > +++ b/hw/9pfs/virtio-9p.c > > @@ -3287,14 +3287,3 @@ void handle_9p_output(VirtIODevice *vdev, VirtQueue *vq) > > } > > free_pdu(s, pdu); > > } > > - > > -static void __attribute__((__constructor__)) virtio_9p_set_fd_limit(void) > > -{ > > - struct rlimit rlim; > > - if (getrlimit(RLIMIT_NOFILE, &rlim) < 0) { > > - fprintf(stderr, "Failed to get the resource limit\n"); > > - exit(1); > > - } > > - open_fd_hw = rlim.rlim_cur - MIN(400, rlim.rlim_cur/3); > > - open_fd_rc = rlim.rlim_cur/2; > > -} > > I am looking at when we stopped using that. We still do file descriptor > reclaim. If we do that we need to set the open_fd_hw/rc. > Indeed this function has no explicit caller but it is not dead code. We must keep it. Wei, no need to repost, I'll fix this in my tree. > > > > diff --git a/hw/9pfs/virtio-9p.h b/hw/9pfs/virtio-9p.h > > index ac4cb00..3c78d3c 100644 > > --- a/hw/9pfs/virtio-9p.h > > +++ b/hw/9pfs/virtio-9p.h > > @@ -227,65 +227,6 @@ typedef struct V9fsState > > V9fsConf fsconf; > >2.1.4 > > -aneesh Thanks Aneesh ! -- Greg