From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752558AbcAGSVS (ORCPT ); Thu, 7 Jan 2016 13:21:18 -0500 Received: from e36.co.us.ibm.com ([32.97.110.154]:33283 "EHLO e36.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709AbcAGSVR (ORCPT ); Thu, 7 Jan 2016 13:21:17 -0500 X-IBM-Helo: d03dlp02.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-next@vger.kernel.org Date: Thu, 7 Jan 2016 10:02:44 -0800 From: "Paul E. McKenney" To: Stephen Rothwell Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux-next: build failure after merge of the rcu tree Message-ID: <20160107180244.GR3818@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20160107195725.3a130b4d@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160107195725.3a130b4d@canb.auug.org.au> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16010718-0021-0000-0000-000015DF36FE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 07, 2016 at 07:57:25PM +1100, Stephen Rothwell wrote: > Hi Paul, > > [I found this a few days ago, but I think I forgot to send the email, > sorry.] > > After merging the rcu tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > kernel/rcu/rcuperf.o:(.discard+0x0): multiple definition of `__pcpu_unique_srcu_ctl_srcu_array' > kernel/rcu/rcutorture.o:(.discard+0x0): first defined here > > Caused by commit > > abcd7ec0808e ("rcutorture: Add RCU grace-period performance tests") > > I have reverted that commit for today. Hello, Stephen, Very strange. The "static" keyword does not mean anything here? Easy enough to use different symbols in the two different files, but this situation is not so good for information hiding. Happy to update rcuperf.c to use a different name, but in the immortal words of MSDOS, "Are you sure?" :-) Thanx, Paul