From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40855)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=80755c3b3=wei.liu2@citrix.com>)
	id 1aHFtx-0003Ms-D9
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 14:07:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <prvs=80755c3b3=wei.liu2@citrix.com>)
	id 1aHFtt-0005Lt-TH
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 14:07:13 -0500
Received: from smtp.citrix.com ([66.165.176.89]:39648)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=80755c3b3=wei.liu2@citrix.com>)
	id 1aHFtt-0005LW-PE
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 14:07:09 -0500
Date: Thu, 7 Jan 2016 19:07:02 +0000
From: Wei Liu <wei.liu2@citrix.com>
Message-ID: <20160107190702.GI1457@citrix.com>
References: <1452020761-24457-1-git-send-email-wei.liu2@citrix.com>
	<1452020761-24457-21-git-send-email-wei.liu2@citrix.com>
	<87egdtqqdy.fsf@linux.vnet.ibm.com> <20160107171606.GF1457@citrix.com>
	<87wprlpadf.fsf@linux.vnet.ibm.com> <20160107174730.GG1457@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20160107174730.GG1457@citrix.com>
Subject: Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from
	virtio-9p.{c, h}
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Wei Liu <wei.liu2@citrix.com>, qemu-devel@nongnu.org, Greg Kurz <gkurz@linux.vnet.ibm.com>

On Thu, Jan 07, 2016 at 05:47:30PM +0000, Wei Liu wrote:
> On Thu, Jan 07, 2016 at 10:58:28PM +0530, Aneesh Kumar K.V wrote:
> > Wei Liu <wei.liu2@citrix.com> writes:
> > 
> > > On Thu, Jan 07, 2016 at 10:27:13PM +0530, Aneesh Kumar K.V wrote:
> > >> Wei Liu <wei.liu2@citrix.com> writes:
> > >> 
> > >> > The vast majority of code in virtio-9p.c is actually generic code.
> > >> > Rename that file to 9p.c and move virtio specific code to
> > >> > virtio-9p-device.c. Rename virtio-9p.h to 9p.h and split out virtio
> > >> > specific code to new virtio-9p.h.
> > >> >
> > >> > Finally fix up virtio-pci.h header file inclusion.
> > >> >
> > >> > Note that V9fsState and V9fsPDU are still tied to virtio at the moment.
> > >> > They will be handled later.
> > >> 
> > >> Can you split this to smaller patches as done for others.
> > >> 
> > >
> > > I'm not sure what you're asking for. IMHO splitting out C and header
> > > file is better done in one single commit.
> > >
> > 
> > virtio-9p.h -> 9p.h one patch
> 
> This can be done.
> 
> > virtio_p9_push_and_notify . There is one other instance of that
> > conversion in the next patch
> 
> The next patch ("9pfs: factor out v9fs_device_{,un}realize_common
> ") doesn't touch virtio_p9_push_and_notify. What do I miss?
> 

I've made a patch to break out v9fs_9p_push_and_notify. I guess that's
what you want.

Wei.