From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752701AbcAGVj6 (ORCPT ); Thu, 7 Jan 2016 16:39:58 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:33380 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbcAGVj4 (ORCPT ); Thu, 7 Jan 2016 16:39:56 -0500 Date: Thu, 7 Jan 2016 13:39:53 -0800 From: Brian Norris To: Shuah Khan Cc: Greg Kroah-Hartman , Ming Lei , Kees Cook , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, "Luis R. Rodriguez" Subject: Re: [PATCH v2 5/5] selftests: firmware: add empty string and async tests Message-ID: <20160107213953.GA49009@google.com> References: <1449701429-121423-1-git-send-email-computersforpeace@gmail.com> <1449701429-121423-5-git-send-email-computersforpeace@gmail.com> <568ED136.40308@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <568ED136.40308@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shuah, On Thu, Jan 07, 2016 at 01:57:26PM -0700, Shuah Khan wrote: > On 12/09/2015 03:50 PM, Brian Norris wrote: > > Now that we've added a 'trigger_async_request' knob to test the > > request_firmware_nowait() API, let's use it. Also add tests for the > > empty ("") string, since there have been a couple errors in that > > handling already. > > > > Since we now have real ways that the sysfs write might fail, let's add > > the appropriate check on the 'echo' lines too. > > > > Signed-off-by: Brian Norris > > Acked-by: Kees Cook > > Thanks for the patch. Applied to linux-kselftest next for 4.5-rc1. Great! Perhaps I'm missing something: I see patches 1-4, but not this patch (patch 5) in: git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git +next Regards, Brian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH v2 5/5] selftests: firmware: add empty string and async tests Date: Thu, 7 Jan 2016 13:39:53 -0800 Message-ID: <20160107213953.GA49009@google.com> References: <1449701429-121423-1-git-send-email-computersforpeace@gmail.com> <1449701429-121423-5-git-send-email-computersforpeace@gmail.com> <568ED136.40308@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <568ED136.40308-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Shuah Khan Cc: Greg Kroah-Hartman , Ming Lei , Kees Cook , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Luis R. Rodriguez" List-Id: linux-api@vger.kernel.org Hi Shuah, On Thu, Jan 07, 2016 at 01:57:26PM -0700, Shuah Khan wrote: > On 12/09/2015 03:50 PM, Brian Norris wrote: > > Now that we've added a 'trigger_async_request' knob to test the > > request_firmware_nowait() API, let's use it. Also add tests for the > > empty ("") string, since there have been a couple errors in that > > handling already. > > > > Since we now have real ways that the sysfs write might fail, let's add > > the appropriate check on the 'echo' lines too. > > > > Signed-off-by: Brian Norris > > Acked-by: Kees Cook > > Thanks for the patch. Applied to linux-kselftest next for 4.5-rc1. Great! Perhaps I'm missing something: I see patches 1-4, but not this patch (patch 5) in: git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git +next Regards, Brian