From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Fri, 08 Jan 2016 01:50:57 +0000 Subject: Re: [PATCH v2 1/4] PCI: rcar: remove unused pci_sys_data structure in pcie-rcar Message-Id: <20160108015056.GB9600@verge.net.au> List-Id: References: <1451998831-27705-1-git-send-email-phil.edworthy@renesas.com> <1451998831-27705-2-git-send-email-phil.edworthy@renesas.com> In-Reply-To: <1451998831-27705-2-git-send-email-phil.edworthy@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Phil Edworthy Cc: Bjorn Helgaas , Wolfram Sang , Geert Uytterhoeven , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org Hi Phil, On Tue, Jan 05, 2016 at 01:00:28PM +0000, Phil Edworthy wrote: > Commit b3a72384fe29 ("ARM/PCI: Replace pci_sys_data->align_resource > with global function pointer") removed the struct pci_sys_data > dependency from the ARM pcibios functions, so remove it from this > driver. I am a little confused by this as I still see two instances of the following in bios32.c as of the commit above. struct pci_sys_data *sys = dev->sysdata; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753840AbcAHBux (ORCPT ); Thu, 7 Jan 2016 20:50:53 -0500 Received: from kirsty.vergenet.net ([202.4.237.240]:32874 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752738AbcAHBuv (ORCPT ); Thu, 7 Jan 2016 20:50:51 -0500 Date: Fri, 8 Jan 2016 10:50:57 +0900 From: Simon Horman To: Phil Edworthy Cc: Bjorn Helgaas , Wolfram Sang , Geert Uytterhoeven , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH v2 1/4] PCI: rcar: remove unused pci_sys_data structure in pcie-rcar Message-ID: <20160108015056.GB9600@verge.net.au> References: <1451998831-27705-1-git-send-email-phil.edworthy@renesas.com> <1451998831-27705-2-git-send-email-phil.edworthy@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451998831-27705-2-git-send-email-phil.edworthy@renesas.com> Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Phil, On Tue, Jan 05, 2016 at 01:00:28PM +0000, Phil Edworthy wrote: > Commit b3a72384fe29 ("ARM/PCI: Replace pci_sys_data->align_resource > with global function pointer") removed the struct pci_sys_data > dependency from the ARM pcibios functions, so remove it from this > driver. I am a little confused by this as I still see two instances of the following in bios32.c as of the commit above. struct pci_sys_data *sys = dev->sysdata;