All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Anju T <anju@linux.vnet.ibm.com>
Cc: mpe@ellerman.id.au, khandual@linux.vnet.ibm.com,
	maddy@linux.vnet.ibm.com, dsahern@gmail.com, acme@redhat.com,
	sukadev@linux.vnet.ibm.com, hemant@linux.vnet.ibm.com,
	naveen.n.rao@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V8 3/4] tools/perf: Map the ID values with register names
Date: Fri, 8 Jan 2016 10:28:18 +0100	[thread overview]
Message-ID: <20160108092818.GB18339@krava.brq.redhat.com> (raw)
In-Reply-To: <1452243751-382-4-git-send-email-anju@linux.vnet.ibm.com>

On Fri, Jan 08, 2016 at 02:32:30PM +0530, Anju T wrote:

SNIP

> +#endif /* ARCH_PERF_REGS_H */
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 38a0853..acf0302 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -23,6 +23,11 @@ $(call detected_var,ARCH)
>  
>  NO_PERF_REGS := 1
>  
> +# Additional ARCH settings for ppc64
> +ifeq ($(ARCH),powerpc)
> +	NO_PERF_REGS := 0
> +endif

please use space for indent in makefiles.. the line might get
switched for rule one day and it's hard to find ;-)

thanks,
jirka

  reply	other threads:[~2016-01-08  9:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08  9:02 [PATCH V8 0/4] perf/powerpc: Add ability to sample intr machine state in powerpc Anju T
2016-01-08  9:02 ` [PATCH V8 1/4] perf/powerpc: assign an id to each powerpc register Anju T
2016-01-08  9:02 ` [PATCH V8 2/4] perf/powerpc: add support for sampling intr machine state Anju T
2016-01-08  9:02 ` [PATCH V8 3/4] tools/perf: Map the ID values with register names Anju T
2016-01-08  9:28   ` Jiri Olsa [this message]
2016-01-08  9:02 ` [PATCH V1 4/4] tool/perf: Add sample_reg_mask to include all perf_regs regs Anju T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160108092818.GB18339@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@redhat.com \
    --cc=anju@linux.vnet.ibm.com \
    --cc=dsahern@gmail.com \
    --cc=hemant@linux.vnet.ibm.com \
    --cc=khandual@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.vnet.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=sukadev@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.