From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHUlY-00071e-CU for qemu-devel@nongnu.org; Fri, 08 Jan 2016 05:59:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHUlU-0006VA-MI for qemu-devel@nongnu.org; Fri, 08 Jan 2016 05:59:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHUlU-0006V5-HD for qemu-devel@nongnu.org; Fri, 08 Jan 2016 05:59:28 -0500 Date: Fri, 8 Jan 2016 10:59:23 +0000 From: "Daniel P. Berrange" Message-ID: <20160108105923.GB14764@redhat.com> References: <1450441266-543-1-git-send-email-berrange@redhat.com> <1450441266-543-5-git-send-email-berrange@redhat.com> <568F7B97.8050206@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <568F7B97.8050206@redhat.com> Subject: Re: [Qemu-devel] [PULL v4 4/9] io: add QIOChannelSocket class Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Maydell , qemu-devel@nongnu.org On Fri, Jan 08, 2016 at 10:04:23AM +0100, Paolo Bonzini wrote: > > > On 18/12/2015 13:21, Daniel P. Berrange wrote: > > + > > + if (nfds > SOCKET_MAX_FDS) { > > + error_setg_errno(errp, -EINVAL, > > + "Only %d FDs can be sent, got %zu", > > + SOCKET_MAX_FDS, nfds); > > + return -1; > > + } > > Hi Daniel, > > the second argument here should be positive (s/-EINVAL/EINVAL). Ok, I'll send followup patch(es) to fix this & the bugs you mention against the other 2 patches. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|