From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Date: Fri, 08 Jan 2016 21:06:35 +0000 Subject: Re: [PATCH v2 1/4] PCI: rcar: remove unused pci_sys_data structure in pcie-rcar Message-Id: <20160108210635.GL5354@localhost> List-Id: References: <1451998831-27705-1-git-send-email-phil.edworthy@renesas.com> <1451998831-27705-2-git-send-email-phil.edworthy@renesas.com> <20160108015056.GB9600@verge.net.au> In-Reply-To: <20160108015056.GB9600@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Simon Horman Cc: Phil Edworthy , Bjorn Helgaas , Wolfram Sang , Geert Uytterhoeven , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org On Fri, Jan 08, 2016 at 10:50:57AM +0900, Simon Horman wrote: > Hi Phil, > > On Tue, Jan 05, 2016 at 01:00:28PM +0000, Phil Edworthy wrote: > > Commit b3a72384fe29 ("ARM/PCI: Replace pci_sys_data->align_resource > > with global function pointer") removed the struct pci_sys_data > > dependency from the ARM pcibios functions, so remove it from this > > driver. > > I am a little confused by this as I still see two instances of > the following in bios32.c as of the commit above. > > struct pci_sys_data *sys = dev->sysdata; This patch only removes a pci_sys_data struct from pcie-rcar.c. That struct was previously used by pci_common_init_dev() and by the ARM pcibios_align_resource(). After cbce7900598c ("PCI: designware: Make driver arch-agnostic"), none of the DesignWare drivers use pci_common_init_dev(), and after b3a72384fe29, ARM doesn't need pci_sys_data for pcibios_align_resource(). Phil can correct me if I'm wrong, but I think this patch is probably OK. I guess we can tell after I apply it and get a build test :) Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756652AbcAHVGl (ORCPT ); Fri, 8 Jan 2016 16:06:41 -0500 Received: from mail.kernel.org ([198.145.29.136]:44789 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752561AbcAHVGj (ORCPT ); Fri, 8 Jan 2016 16:06:39 -0500 Date: Fri, 8 Jan 2016 15:06:35 -0600 From: Bjorn Helgaas To: Simon Horman Cc: Phil Edworthy , Bjorn Helgaas , Wolfram Sang , Geert Uytterhoeven , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH v2 1/4] PCI: rcar: remove unused pci_sys_data structure in pcie-rcar Message-ID: <20160108210635.GL5354@localhost> References: <1451998831-27705-1-git-send-email-phil.edworthy@renesas.com> <1451998831-27705-2-git-send-email-phil.edworthy@renesas.com> <20160108015056.GB9600@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160108015056.GB9600@verge.net.au> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 08, 2016 at 10:50:57AM +0900, Simon Horman wrote: > Hi Phil, > > On Tue, Jan 05, 2016 at 01:00:28PM +0000, Phil Edworthy wrote: > > Commit b3a72384fe29 ("ARM/PCI: Replace pci_sys_data->align_resource > > with global function pointer") removed the struct pci_sys_data > > dependency from the ARM pcibios functions, so remove it from this > > driver. > > I am a little confused by this as I still see two instances of > the following in bios32.c as of the commit above. > > struct pci_sys_data *sys = dev->sysdata; This patch only removes a pci_sys_data struct from pcie-rcar.c. That struct was previously used by pci_common_init_dev() and by the ARM pcibios_align_resource(). After cbce7900598c ("PCI: designware: Make driver arch-agnostic"), none of the DesignWare drivers use pci_common_init_dev(), and after b3a72384fe29, ARM doesn't need pci_sys_data for pcibios_align_resource(). Phil can correct me if I'm wrong, but I think this patch is probably OK. I guess we can tell after I apply it and get a build test :) Bjorn