From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755183AbcAIBOY (ORCPT ); Fri, 8 Jan 2016 20:14:24 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35751 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750875AbcAIBOW (ORCPT ); Fri, 8 Jan 2016 20:14:22 -0500 Date: Sat, 9 Jan 2016 10:12:41 +0900 From: Sergey Senozhatsky To: Andy Shevchenko Cc: Tejun Heo , Linus Walleij , Dmitry Eremin-Solenikov , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "David S. Miller" , David Airlie , Andrew Morton , Rasmus Villemoes , Sergey Senozhatsky , Sergey Senozhatsky Subject: Re: [PATCH v1 1/8] lib/string: introduce match_string() helper Message-ID: <20160109011241.GB560@swordfish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452242596.30729.425.camel@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Shevchenko wrote: [..] > > > > strncmp() case seems to be quite common. > > Like I answered to Rasmus, please, provide real examples. [..] > > int nmatch_string(array, array_size, string, string_len) > > { > > do { > > strncmp(); > > } while (); > > } > > > > int match_string(array, array_size, string) > > { > > return nmatch_string(array, array_size, string, > > strlen(string)); > > } > > See above. after some quick and inaccurate grepping, well, probably you're right - not worth it. arch/mips/bcm63xx/boards/board_bcm963xx.c void __init board_prom_init(void) net/irda/irnet/irnet_irda.c irnet_dname_to_daddr() arch/powerpc/sysdev/ppc4xx_cpm.c static ssize_t cpm_idle_store() arch/x86/ras/mce_amd_inj.c static int __set_inj drivers/hwtracing/intel_th/msu.c mode_store drivers/pci/pcie/aer/ecrc.c void pcie_ecrc_get_policy drivers/pci/pcie/aspm.c pcie_aspm_set_policy drivers/scsi/aic7xxx/aic7xxx_osm.c aic7xxx_setup drivers/scsi/aic7xxx/aic79xx_osm.c aic79xx_setup drivers/scsi/scsi_transport_fc.c static int get_fc_##title##_match drivers/staging/android/ion/hisilicon/hi6220_ion.c get_type_by_name drivers/staging/lustre/lustre/lmv/lproc_lmv.c placement_name2policy drivers/xen/sys-hypervisor.c pmu_mode_store -ss