From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 34/35] block: add QUEUE_FLAGs for flush and fua Date: Sat, 9 Jan 2016 00:04:26 -0800 Message-ID: <20160109080426.GA6207@infradead.org> References: <1452027218-32303-1-git-send-email-mchristi@redhat.com> <1452027218-32303-35-git-send-email-mchristi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1452027218-32303-35-git-send-email-mchristi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org Errors-To: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org To: mchristi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Cc: linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org, ocfs2-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org, linux-f2fs-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, osd-dev-yNzVSZO3znNg9hUCZPvPmw@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lars.ellenberg-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org List-Id: linux-raid.ids On Tue, Jan 05, 2016 at 02:53:37PM -0600, mchristi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org wrote: > From: Mike Christie > > The last patch added a REQ_OP_FLUSH for request_fn drivers > and the next patch renames REQ_FLUSH to REQ_PREFLUSH which > will be used by file systems and make_request_fn drivers. > > This leaves REQ_FLUSH/REQ_FUA defined for drivers to tell > the block layer if flush/fua is supported. The names are > confusing and I bet will will accidentally be used by > people to request flushes. To avoid that, this patch adds > QUEUE_FLAGs for flush and fua which drivers will use to > indicate what they support. > > Signed-off-by: Mike Christie Yes, this was rather confusing before. Looks great fix the fix for th kbuild complaint: Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:60629 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752189AbcAIIE3 (ORCPT ); Sat, 9 Jan 2016 03:04:29 -0500 Date: Sat, 9 Jan 2016 00:04:26 -0800 From: Christoph Hellwig To: mchristi@redhat.com Cc: linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org, konrad.wilk@oracle.com, drbd-dev@lists.linbit.com, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, linux-raid@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, linux-bcache@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-mtd@lists.infradead.org, target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, osd-dev@open-osd.org, xfs@oss.sgi.com, ocfs2-devel@oss.oracle.com Subject: Re: [PATCH 34/35] block: add QUEUE_FLAGs for flush and fua Message-ID: <20160109080426.GA6207@infradead.org> References: <1452027218-32303-1-git-send-email-mchristi@redhat.com> <1452027218-32303-35-git-send-email-mchristi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1452027218-32303-35-git-send-email-mchristi@redhat.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Tue, Jan 05, 2016 at 02:53:37PM -0600, mchristi@redhat.com wrote: > From: Mike Christie > > The last patch added a REQ_OP_FLUSH for request_fn drivers > and the next patch renames REQ_FLUSH to REQ_PREFLUSH which > will be used by file systems and make_request_fn drivers. > > This leaves REQ_FLUSH/REQ_FUA defined for drivers to tell > the block layer if flush/fua is supported. The names are > confusing and I bet will will accidentally be used by > people to request flushes. To avoid that, this patch adds > QUEUE_FLAGs for flush and fua which drivers will use to > indicate what they support. > > Signed-off-by: Mike Christie Yes, this was rather confusing before. Looks great fix the fix for th kbuild complaint: Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 5A4E77F37 for ; Sat, 9 Jan 2016 02:04:46 -0600 (CST) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 492598F8033 for ; Sat, 9 Jan 2016 00:04:43 -0800 (PST) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id p49wRfF8uSqzTLBj (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Sat, 09 Jan 2016 00:04:41 -0800 (PST) Date: Sat, 9 Jan 2016 00:04:26 -0800 From: Christoph Hellwig Subject: Re: [PATCH 34/35] block: add QUEUE_FLAGs for flush and fua Message-ID: <20160109080426.GA6207@infradead.org> References: <1452027218-32303-1-git-send-email-mchristi@redhat.com> <1452027218-32303-35-git-send-email-mchristi@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1452027218-32303-35-git-send-email-mchristi@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: mchristi@redhat.com Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org, xfs@oss.sgi.com, ocfs2-devel@oss.oracle.com, linux-scsi@vger.kernel.org, konrad.wilk@oracle.com, linux-kernel@vger.kernel.org, philipp.reisner@linbit.com, linux-f2fs-devel@lists.sourceforge.net, linux-raid@vger.kernel.org, dm-devel@redhat.com, target-devel@vger.kernel.org, linux-mtd@lists.infradead.org, osd-dev@open-osd.org, linux-fsdevel@vger.kernel.org, lars.ellenberg@linbit.com, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, drbd-dev@lists.linbit.com On Tue, Jan 05, 2016 at 02:53:37PM -0600, mchristi@redhat.com wrote: > From: Mike Christie > > The last patch added a REQ_OP_FLUSH for request_fn drivers > and the next patch renames REQ_FLUSH to REQ_PREFLUSH which > will be used by file systems and make_request_fn drivers. > > This leaves REQ_FLUSH/REQ_FUA defined for drivers to tell > the block layer if flush/fua is supported. The names are > confusing and I bet will will accidentally be used by > people to request flushes. To avoid that, this patch adds > QUEUE_FLAGs for flush and fua which drivers will use to > indicate what they support. > > Signed-off-by: Mike Christie Yes, this was rather confusing before. Looks great fix the fix for th kbuild complaint: Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Sat, 9 Jan 2016 00:04:26 -0800 Subject: [Ocfs2-devel] [PATCH 34/35] block: add QUEUE_FLAGs for flush and fua In-Reply-To: <1452027218-32303-35-git-send-email-mchristi@redhat.com> References: <1452027218-32303-1-git-send-email-mchristi@redhat.com> <1452027218-32303-35-git-send-email-mchristi@redhat.com> Message-ID: <20160109080426.GA6207@infradead.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: mchristi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Cc: linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org, ocfs2-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org, linux-f2fs-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, osd-dev-yNzVSZO3znNg9hUCZPvPmw@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lars.ellenberg-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org On Tue, Jan 05, 2016 at 02:53:37PM -0600, mchristi at redhat.com wrote: > From: Mike Christie > > The last patch added a REQ_OP_FLUSH for request_fn drivers > and the next patch renames REQ_FLUSH to REQ_PREFLUSH which > will be used by file systems and make_request_fn drivers. > > This leaves REQ_FLUSH/REQ_FUA defined for drivers to tell > the block layer if flush/fua is supported. The names are > confusing and I bet will will accidentally be used by > people to request flushes. To avoid that, this patch adds > QUEUE_FLAGs for flush and fua which drivers will use to > indicate what they support. > > Signed-off-by: Mike Christie Yes, this was rather confusing before. Looks great fix the fix for th kbuild complaint: Reviewed-by: Christoph Hellwig