From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 26/35] block: set op to REQ_OP Date: Sat, 9 Jan 2016 05:39:18 -0800 Message-ID: <20160109133918.GC26660@infradead.org> References: <1452027218-32303-1-git-send-email-mchristi@redhat.com> <1452027218-32303-27-git-send-email-mchristi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1452027218-32303-27-git-send-email-mchristi@redhat.com> Sender: linux-raid-owner@vger.kernel.org To: mchristi@redhat.com Cc: linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org, konrad.wilk@oracle.com, drbd-dev@lists.linbit.com, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, linux-raid@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, linux-bcache@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-mtd@lists.infradead.org, target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, osd-dev@open-osd.org, xfs@oss.sgi.com, ocfs2-devel@oss.oracle.com List-Id: linux-raid.ids > @@ -1149,10 +1151,12 @@ static struct request *__get_request(struct request_list *rl, int rw_flags, > > blk_rq_init(q, rq); > blk_rq_set_rl(rq, rl); > - rq->cmd_flags = rw_flags | REQ_ALLOCED; > + /* tmp compat - allow users to check either one for the op */ > + rq->cmd_flags = op | op_flags | REQ_ALLOCED; This one is still left after the whole series is applied, seems like the hunk to remove it again got lost somewhere. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 988797F37 for ; Sat, 9 Jan 2016 07:39:30 -0600 (CST) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay3.corp.sgi.com (Postfix) with ESMTP id 242EBAC002 for ; Sat, 9 Jan 2016 05:39:30 -0800 (PST) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id lqnHYmh9yCSnE1HQ (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Sat, 09 Jan 2016 05:39:28 -0800 (PST) Date: Sat, 9 Jan 2016 05:39:18 -0800 From: Christoph Hellwig Subject: Re: [PATCH 26/35] block: set op to REQ_OP Message-ID: <20160109133918.GC26660@infradead.org> References: <1452027218-32303-1-git-send-email-mchristi@redhat.com> <1452027218-32303-27-git-send-email-mchristi@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1452027218-32303-27-git-send-email-mchristi@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: mchristi@redhat.com Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org, xfs@oss.sgi.com, ocfs2-devel@oss.oracle.com, linux-scsi@vger.kernel.org, konrad.wilk@oracle.com, linux-kernel@vger.kernel.org, philipp.reisner@linbit.com, linux-f2fs-devel@lists.sourceforge.net, linux-raid@vger.kernel.org, dm-devel@redhat.com, target-devel@vger.kernel.org, linux-mtd@lists.infradead.org, osd-dev@open-osd.org, linux-fsdevel@vger.kernel.org, lars.ellenberg@linbit.com, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, drbd-dev@lists.linbit.com > @@ -1149,10 +1151,12 @@ static struct request *__get_request(struct request_list *rl, int rw_flags, > > blk_rq_init(q, rq); > blk_rq_set_rl(rq, rl); > - rq->cmd_flags = rw_flags | REQ_ALLOCED; > + /* tmp compat - allow users to check either one for the op */ > + rq->cmd_flags = op | op_flags | REQ_ALLOCED; This one is still left after the whole series is applied, seems like the hunk to remove it again got lost somewhere. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Sat, 9 Jan 2016 05:39:18 -0800 Subject: [Ocfs2-devel] [PATCH 26/35] block: set op to REQ_OP In-Reply-To: <1452027218-32303-27-git-send-email-mchristi@redhat.com> References: <1452027218-32303-1-git-send-email-mchristi@redhat.com> <1452027218-32303-27-git-send-email-mchristi@redhat.com> Message-ID: <20160109133918.GC26660@infradead.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: mchristi@redhat.com Cc: linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org, konrad.wilk@oracle.com, drbd-dev@lists.linbit.com, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, linux-raid@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, linux-bcache@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-mtd@lists.infradead.org, target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, osd-dev@open-osd.org, xfs@oss.sgi.com, ocfs2-devel@oss.oracle.com > @@ -1149,10 +1151,12 @@ static struct request *__get_request(struct request_list *rl, int rw_flags, > > blk_rq_init(q, rq); > blk_rq_set_rl(rq, rl); > - rq->cmd_flags = rw_flags | REQ_ALLOCED; > + /* tmp compat - allow users to check either one for the op */ > + rq->cmd_flags = op | op_flags | REQ_ALLOCED; This one is still left after the whole series is applied, seems like the hunk to remove it again got lost somewhere.