All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: linux-pm@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Zhang Rui <rui.zhang@intel.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: [PATCH 2/3] cpuidle: Default to ladder governor on ticking systems
Date: Mon, 11 Jan 2016 17:41:53 +0100	[thread overview]
Message-ID: <20160111174153.3918f419@endymion.delvare> (raw)
In-Reply-To: <20160111173915.63ec1bcd@endymion.delvare>

The menu governor is currently the default on all systems. However the
documentation claims that the ladder governor is preferred on ticking
systems. So bump the rating of the ladder governor when NO_HZ is
disabled, or when booting with nohz=off.

This fixes the first half of bug #65531:
https://bugzilla.kernel.org/show_bug.cgi?id=65531

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Zhang Rui <rui.zhang@intel.com>
---
 drivers/cpuidle/governors/ladder.c |    9 +++++++++
 1 file changed, 9 insertions(+)

--- linux-4.4.orig/drivers/cpuidle/governors/ladder.c	2016-01-11 16:14:57.962027330 +0100
+++ linux-4.4/drivers/cpuidle/governors/ladder.c	2016-01-11 16:15:57.217301178 +0100
@@ -17,6 +17,7 @@
 #include <linux/pm_qos.h>
 #include <linux/module.h>
 #include <linux/jiffies.h>
+#include <linux/tick.h>
 
 #include <asm/io.h>
 #include <asm/uaccess.h>
@@ -184,6 +185,14 @@ static struct cpuidle_governor ladder_go
  */
 static int __init init_ladder(void)
 {
+	/*
+	 * When NO_HZ is disabled, or when booting with nohz=off, the ladder
+	 * governor is better so give it a higher rating than the menu
+	 * governor.
+	 */
+	if (!tick_nohz_enabled)
+		ladder_governor.rating = 25;
+
 	return cpuidle_register_governor(&ladder_governor);
 }
 

-- 
Jean Delvare
SUSE L3 Support

  parent reply	other threads:[~2016-01-11 16:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-11 16:39 [PATCH 0/3] Use the ladder cpuidle governor when appropriate Jean Delvare
2016-01-11 16:40 ` [PATCH 1/3] Subject: nohz: Expose tick_nohz_enabled Jean Delvare
2016-01-11 16:44   ` Jean Delvare
2016-01-11 17:10   ` Thomas Gleixner
2016-01-11 16:41 ` Jean Delvare [this message]
2016-01-11 16:43 ` [PATCH 3/3] cpuidle: Don't enable all governors by default Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160111174153.3918f419@endymion.delvare \
    --to=jdelvare@suse.de \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=rui.zhang@intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.