From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753981AbcALUrW (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 Jan 2016 15:47:22 -0500
Received: from shards.monkeyblade.net ([149.20.54.216]:53884 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753079AbcALUrU (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 Jan 2016 15:47:20 -0500
Date: Tue, 12 Jan 2016 15:47:18 -0500 (EST)
Message-Id: <20160112.154718.762462936767801736.davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: ivo.g.dimitrov.75@gmail.com, courmisch@gmail.com, noureddine@arista.com,
        pali.rohar@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, sre@kernel.org,
        linux-omap@vger.kernel.org
Subject: Re: [PATCH net] phonet: properly unshare skbs in phonet_rcv()
From: David Miller <davem@davemloft.net>
In-Reply-To: <1452617880.1223.21.camel@edumazet-glaptop2.roam.corp.google.com>
References: <5694A840.8030900@gmail.com>
	<1452608377.1223.13.camel@edumazet-glaptop2.roam.corp.google.com>
	<1452617880.1223.21.camel@edumazet-glaptop2.roam.corp.google.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 12 Jan 2016 12:47:20 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 12 Jan 2016 08:58:00 -0800

> From: Eric Dumazet <edumazet@google.com>
> 
> Ivaylo Dimitrov reported a regression caused by commit 7866a621043f
> ("dev: add per net_device packet type chains").
> 
> skb->dev becomes NULL and we crash in __netif_receive_skb_core().
> 
> Before above commit, different kind of bugs or corruptions could happen
> without major crash.
> 
> But the root cause is that phonet_rcv() can queue skb without checking
> if skb is shared or not.
> 
> Many thanks to Ivaylo Dimitrov for his help, diagnosis and tests.
> 
> Reported-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> Tested-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Remi Denis-Courmont <courmisch@gmail.com>

Applied and queued up for -stable, th anks Eric.