All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Mendoza-Jonas <sam@mendozajonas.com>
To: OpenBMC Patches <openbmc-patches@stwcx.xyz>
Cc: openbmc@lists.ozlabs.org, shgoupf <shgoupf@cn.ibm.com>
Subject: Re: [PATCH phosphor-host-ipmid v7] Add get/set boot option ipmid command support with correct DBUS property handling.
Date: Tue, 12 Jan 2016 13:02:28 +1100	[thread overview]
Message-ID: <20160112020228.GA19934@localhost.localdomain> (raw)
In-Reply-To: <1452559839-27825-2-git-send-email-openbmc-patches@stwcx.xyz>

Hi,

On Mon, Jan 11, 2016 at 06:50:39PM -0600, OpenBMC Patches wrote:
> From: shgoupf <shgoupf@cn.ibm.com>

(snip)

> -        memcpy(response, &buf, *data_len);
> +        uint64_t return_value;
> +        sscanf(buf, "%PRIx64", &return_value);

I just noticed this change from the previous version; have you tested
this? I believe you need to use the PRIx64 specifier like this:

	sscanf(buf, "%" PRIx64, &return_value);

Where PRIx64 is not within the quotes. Do you get an error when you
build this?

Regards,
Sam Mendoza-Jonas

  reply	other threads:[~2016-01-12  2:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-12  0:50 [PATCH phosphor-host-ipmid v7] Add get/set ipmid command support with correct DBUS property handling OpenBMC Patches
2016-01-12  0:50 ` [PATCH phosphor-host-ipmid v7] Add get/set boot option " OpenBMC Patches
2016-01-12  2:02   ` Sam Mendoza-Jonas [this message]
2016-01-12  2:57     ` Peng Fei BG Gou
2016-01-12  5:45 ` [PATCH phosphor-host-ipmid v7] Add get/set " Stewart Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160112020228.GA19934@localhost.localdomain \
    --to=sam@mendozajonas.com \
    --cc=openbmc-patches@stwcx.xyz \
    --cc=openbmc@lists.ozlabs.org \
    --cc=shgoupf@cn.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.