From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIqc0-0001El-Fi for qemu-devel@nongnu.org; Mon, 11 Jan 2016 23:31:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aIqbz-0001i3-8x for qemu-devel@nongnu.org; Mon, 11 Jan 2016 23:31:16 -0500 Date: Tue, 12 Jan 2016 15:13:13 +1100 From: David Gibson Message-ID: <20160112041313.GM22925@voom.redhat.com> References: <1452236119-24452-1-git-send-email-bharata@linux.vnet.ibm.com> <1452236119-24452-6-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4Y142/9l9nQlBiaj" Content-Disposition: inline In-Reply-To: <1452236119-24452-6-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v6 05/11] cpu: Reclaim vCPU objects List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: Zhu Guihua , mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, agraf@suse.de, qemu-devel@nongnu.org, Chen Fan , pbonzini@redhat.com, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com, Gu Zheng , imammedo@redhat.com, afaerber@suse.de, ehabkost@redhat.com --4Y142/9l9nQlBiaj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 08, 2016 at 12:25:13PM +0530, Bharata B Rao wrote: > From: Gu Zheng >=20 > In order to deal well with the kvm vcpus (which can not be removed withou= t any > protection), we do not close KVM vcpu fd, just record and mark it as stop= ped > into a list, so that we can reuse it for the appending cpu hot-add reques= t if > possible. It is also the approach that kvm guys suggested: > https://www.mail-archive.com/kvm@vger.kernel.org/msg102839.html >=20 > Signed-off-by: Chen Fan > Signed-off-by: Gu Zheng > Signed-off-by: Zhu Guihua > Signed-off-by: Bharata B Rao > [- Explicit CPU_REMOVE() from qemu_kvm/tcg_destroy_vcpu() > isn't needed as it is done from cpu_exec_exit() > - Use iothread mutex instead of global mutex during > destroy > - Don't cleanup vCPU object from vCPU thread context > but leave it to the callers (device_add/device_del)] Reviewed-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --4Y142/9l9nQlBiaj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWlH1ZAAoJEGw4ysog2bOSdHcP/AtQrtIW97E13vUTckNLqwFD h84ZfHL718pIGMFy/+7cpxCDJamr9W1U3EqXCY+wrl0TZ5qqJPOzaQEj8cAoH83c 85q8neDujLXnup0frPcAY/hgdKBvqc/7FGpZHwZ/FC21ncpPgKGrS9fzSe0FisMn zrGRNyrKXbB9N/JEwKgTIb+OvHgFa3aG0nyuuHaZLfnhyUa8a6L7qUNs2Y+NbtFL Nh2ADE6wuUhpVK/2J9cRjHgN5VMbKH/Vn2FExBePFchZm4n2d2IQDUSrY6935LEi nvNVABmt9dqpRDBqcsOoKG7FGRCoVyfZWJ5rMSt15tTRfE17f7Zs0wP5ZwrLOK+m XxKToR/zKr+VVntLhbqYxoVLzh9LqDWvDwfezML5VbWxGdY8qkZVu18c9kTxo0hZ gwMU365y0xuzPlA7jdiokzcad5l1TRl44zyjnirURqyyzhnJKCafHsoalTXkh+/L IeiFfqZDpv64lNOTflTFNZxCF2/wYLdpGNWbalarv8Qti/OMaKNtbCOBgu08Fw5j OaHItQi9cuYHx1D5WwnIVq93GNDdrAT6iP+0p+cCWQEaeSAHby07li0eYu+TNZc+ bUe4xExWGU2XtsP0lcIpWrj1ORhBgeOTpcW4SmkAuRQV5psGdUjJeTVGjYlYq8qz KhMlWS6yEOxfT4GXjNaO =vpZ0 -----END PGP SIGNATURE----- --4Y142/9l9nQlBiaj--