From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934042AbcALJFo (ORCPT ); Tue, 12 Jan 2016 04:05:44 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:33950 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933355AbcALJFg (ORCPT ); Tue, 12 Jan 2016 04:05:36 -0500 Date: Tue, 12 Jan 2016 09:05:32 +0000 From: Lee Jones To: SF Markus Elfring Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 2/2] mfd: smsc-ece1099: Refactoring for smsc_i2c_probe() Message-ID: <20160112090532.GS19803@x1> References: <566ABCD9.1060404@users.sourceforge.net> <5682957F.5000604@users.sourceforge.net> <56829630.6030706@users.sourceforge.net> <20160111081059.GS3331@x1> <20160111081219.GT3331@x1> <5694BE21.3010504@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5694BE21.3010504@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please refrain from replying off-list. Adding back the Cc's. On Tue, 12 Jan 2016, SF Markus Elfring wrote: > > Oh, the subject line is also duff. Please describe the changes properly. > > > > "refactoring X", "making changes to Y" are not good subject lines. > > Which topic would you prefer for my update suggestion instead? This one. "mfd: smsc-ece1099: Refactoring for smsc_i2c_probe()" The function name and just describing the changes as "refactoring" do not describe the changes in a helpful way. > >> Code looks fine however. > > Thanks for your look. > > > >> Please re-submit the set with the aforementioned changes along with my: > >> > >> Acked-by: Lee Jones > > Do you really request that I should append this tag already to messages > for (my adjusted) commits you can not see so far? Yes. The code looks fine, and if the commit log is still not up to scratch I just won't apply it. :) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Tue, 12 Jan 2016 09:05:32 +0000 Subject: Re: [PATCH 2/2] mfd: smsc-ece1099: Refactoring for smsc_i2c_probe() Message-Id: <20160112090532.GS19803@x1> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5682957F.5000604@users.sourceforge.net> <56829630.6030706@users.sourceforge.net> <20160111081059.GS3331@x1> <20160111081219.GT3331@x1> <5694BE21.3010504@users.sourceforge.net> In-Reply-To: <5694BE21.3010504@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: SF Markus Elfring Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Please refrain from replying off-list. Adding back the Cc's. On Tue, 12 Jan 2016, SF Markus Elfring wrote: > > Oh, the subject line is also duff. Please describe the changes properl= y. > >=20 > > "refactoring X", "making changes to Y" are not good subject lines. >=20 > Which topic would you prefer for my update suggestion instead? This one. "mfd: smsc-ece1099: Refactoring for smsc_i2c_probe()" The function name and just describing the changes as "refactoring" do not describe the changes in a helpful way. > >> Code looks fine however. >=20 > Thanks for your look. >=20 >=20 > >> Please re-submit the set with the aforementioned changes along with my: > >> > >> Acked-by: Lee Jones >=20 > Do you really request that I should append this tag already to messages > for (my adjusted) commits you can not see so far? Yes. The code looks fine, and if the commit log is still not up to scratch I just won't apply it. :) --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html