From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965014AbcALKpx (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 Jan 2016 05:45:53 -0500
Received: from mail-wm0-f66.google.com ([74.125.82.66]:33934 "EHLO
	mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933352AbcALKps (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 Jan 2016 05:45:48 -0500
Date: Tue, 12 Jan 2016 11:45:44 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Shuah Khan <shuahkh@osg.samsung.com>, Andy Lutomirski <luto@kernel.org>,
        X86 ML <x86@kernel.org>, Borislav Petkov <bp@alien8.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests/x86: Disable ldt_gdt_64 for now
Message-ID: <20160112104544.GA7121@gmail.com>
References: <8dd42ba6434d84eefe6d864fb453fbe34d43098c.1452109816.git.luto@kernel.org>
 <568ECF61.4040007@osg.samsung.com>
 <20160111105933.GA663@gmail.com>
 <CALCETrVhLMT7qS-Tf9-dpcKuqspek1TbrGxL8qPhW4ft2_b7Mw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALCETrVhLMT7qS-Tf9-dpcKuqspek1TbrGxL8qPhW4ft2_b7Mw@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Andy Lutomirski <luto@amacapital.net> wrote:

> On Mon, Jan 11, 2016 at 2:59 AM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * Shuah Khan <shuahkh@osg.samsung.com> wrote:
> >
> >> On 01/06/2016 12:51 PM, Andy Lutomirski wrote:
> >> > ldt_gdt.c relies on cross-cpu invalidation of SS to do one of its
> >> > tests.  On 32-bit builds, this works fine, but on 64-bit builds, it
> >> > only works if the kernel has proper SS sigcontext handling for
> >> > 64-bit user programs.
> >> >
> >> > Since the SS fixes are currently reverted, restrict the test case to
> >> > 32 bits for now.
> >> >
> >> > In principle, I could change the test to use a different segment
> >> > register, but it would be messy: CS can't point to the LDT for
> >> > 64-bit code, and the other registers don't result in immediate
> >> > faults because they aren't reloaded on kernel -> user transitions.
> >> >
> >> > When we fix sigcontext (in 4.6?), we can revert this.
> >> >
> >> > Signed-off-by: Andy Lutomirski <luto@kernel.org>
> >> > --
> >>
> >> Andy,
> >>
> >> This patch didn't apply to linux-kselftest next.
> >> It probably has to go through x86.
> >
> > It doesn't apply to -tip either. Andy, which tree is this against?
> 
> Oops, it applies on top of a new self-test that I forgot to send.  I
> send a v2 that should be better.  I'll send the new selftest out as
> well once -tip catches up with all the vdso patches.

Ok, sounds great!

Thanks,

	Ingo